App: [HOLD for payment 2023-06-13] [$1000] Dev: Not able to run storybook

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to the app folder on terminal
  2. Run command: npm run storybook

Expected Result:

Not able to run storybook

Actual Result:

Crash during building storybook

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: n/a

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (45)

Expensify/Expensify Issue URL:

Issue reported by: Robert Kozik (@robertKozik)

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685043545129419

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ba9220f901f5a917
  • Upwork Job ID: 1664323419533189120
  • Last Price Increase: 2023-06-01

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 39 (27 by maintainers)

Most upvoted comments

Hi! Im contributor from Software Mansion agency so I’m not eligible to payment 😄

Yeah, since we added automated tests, I agree we don’t need to add other regression tests.

Maybe let’s at least identify the PR that added the regression and make sure that it was tested properly? So basically do the first two checkboxes of the checklist.

I think because this statement will fail.

Can you elaborate more ? how will that fails ? As I can see the the webpackConfig sets default value for envFile

https://github.com/Expensify/App/blob/145dd4b8664d3e0b339483cbd9a6441ef9382953/config/webpack/webpack.common.js#L50

You’re actually correct. I’ve updated my proposal 😅

Oh wait, this is a duplicate of https://github.com/Expensify/App/issues/15042. Closing.

@sakluger I don’t think that the two are related.