App: [HOLD for payment 2023-06-12] [Tracking Issue]Bug fixes: 2FA

Here is the list of minor Tracking 2FA bugs to make a quick follow up PR and fix all of them

  1. Missing Download translation in Spanish - https://expensify.slack.com/archives/C049HHMV9SM/p1684406965776349
  2. Two-factor name is inconsistent https://expensify.slack.com/archives/C049HHMV9SM/p1684406403576119
  3. Offline Indicator displayed twice https://expensify.slack.com/archives/C049HHMV9SM/p1684408727072029
  4. Here is your magic code page appears https://expensify.slack.com/archives/C049HHMV9SM/p1684405641601719
  5. Error message persists https://expensify.slack.com/archives/C049HHMV9SM/p1684404156826129
  6. View disrupted on small screen devices https://expensify.slack.com/archives/C049HHMV9SM/p1684392775324939

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 35 (25 by maintainers)

Most upvoted comments

Paid out and ended the contract for @aman-atg. Sounds like we’re all done here, so closing this one out.

OKok sorry for the confusion, I think I was able to get this sorted:

  • C+ for PR review: ~@gadhiyamanan~ extended offer to @mananjadhav, this has been paid
  • Missing Download translation in Spanish - Reporting: ~@ayazhussain79~ extended offer to @aman-atg
  • Two-factor name is inconsistent - Reporting: @Natnael-Guchima this has been paid
  • Offline Indicator displayed twice - Reporting: ~@dhairyasenjaliya~ not paying on this issue, handling elsewhere
  • Here is your magic code page appears Reporting: @Natnael-Guchima this has been paid
  • Error message persists Reporting: @Nathan-Mulugeta this has been paid
  • View disrupted on small screen devices - Reporting: @ayazhussain79 offer extended

Leaving the contracts open just in case I need to swap anything around again 😅, will close by EOD tomorrow once payment is issued for the remaining 2.

@stephanieelliott you accidentally sent me job offer instead of @mananjadhav 😅

Reapplying the Bug label to get another BZ member on this while I am OOO til July 3. Thanks @bfitzexpensify, only thing to do here is issue payment to @aman-atg. The job was extended to them in Upwork, we are just waiting for them to accept is so we can make the payment and close the contract. All others have been paid!

hey @stephanieelliott can you also please close the my contract since we handling it elsewhere

Tough one @stephanieelliott. Thanks for clearing this one out. Appreciate it!

@aman-atg sorry, fixed that

PR is merged! We need to pay all reporters and @mananjadhav for PR review next week

Still working through reviews on the PR.

@stephanieelliott this feature (2FA) went out today and we instantly got bug reports from our wonderful open source community. Thankfully all are minor bugs. I have compiled a list have asked for help in #callstack. We can squash them soon 🚫 🐛 https://expensify.slack.com/archives/C03UK30EA1Z/p1684415073652249