App: [HOLD for payment 2023-03-13] [$1000] Whitespace above block quotes is stripped away
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Compose a message like this:
I am writing a message and it includes a quote:
> This is a quote – notice that there is a blank line above it.
See how I've typed even spacing above and below that block quote?
- Post the message
- Edit the message you posted
Expected Result:
There should be a blank line (and an even amount of space) above and below the block quote. The same message you sent in step 1 should be shown in the editor.
Actual Result:
There’s no blank line above the block quote. Edit message shown as
I am writing a message and it includes a quote:
> This is a quote – notice that there is a blank line above it.
See how I've typed even spacing above and below that block quote?
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.67-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @roryabraham Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675803452308849
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0162b44ca1f9c03f85
- Upwork Job ID: 1623397585262231552
- Last Price Increase: 2023-02-15
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 53 (40 by maintainers)
My bad, this one slipped through the cracks while I was reviewing the proposal
That proposal looks good, 🚀
@abekkala I’ve just applied to the Upwork job, thanks
Payments to be made on MAR 13
Issue reported by: @roryabraham 🎉 no payment for you 😉 Selected Proposal for fix: @tienifr [$1000] C+ Review: @rushatgabhane [$1000]
Accepted Proposal: Feb 22 Merged PR: Mar 02 6 Business Days
No regressions! 🎉
@dangrous
Because the flag was already added in this PR https://github.com/Expensify/App/pull/14822/files and turned on for native code so the additional tests for iOS/Android are working. cc @rushatgabhane
@tienifr we’ll just need to take care of all the regressions that this might introduce. All previous hacks related to
brwould have to be undone