App: [HOLD for payment 2023-03-13] [$1000] Deep link for user profile crashes on desktop
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- On web navigate to a user profile
- Refresh the browser
- Click on
Open Electronto open the user profile
Expected Result:
Open the user profile page in the Desktop app
Actual Result:
Desktop app crashes
Workaround:
Open the user profile on web by clicking on open this link in your browser.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.69-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation: https://expensify.slack.com/archives/C03KN50J0PM/p1676058166922359?thread_ts=1676038239.279419&cid=C03KN50J0PM
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d2a5e261c3af7e82
- Upwork Job ID: 1625199243747147776
- Last Price Increase: 2023-02-17
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 47 (29 by maintainers)
Regression Test Proposal
@allroundexperts @tienifr DO NOT update your proposals by taking suggestions from other proposals. Respect everyone’s efforts and time. @allroundexperts I can see that you added We can add location hash as well to be bulletproof. later. It might be possible that it’s your idea alone but I don’t believe in coincidences.
Thanks.
Thanks for the proposals, everyone. Please do not post partial proposals and then complete them with edits. Try to the complete solution at once. This does not mean you can’t update and can’t add more details.
Tough call here. I like @allroundexperts’s proposal here as they were the first to post a sufficient solution to fix this problem.
Hashis good to add but it is not needed to solve this issue so I will keep that out of comparison.cc: @marcochavezf
🎀 👀 🎀 C+ reviewed
@parasharrajat 👍 resent - https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/23883082
@slafortune Can you please resend the offer? It seems that I accidentally declined it.
Ah! Thanks for calling that out! I was using the incorrect dates!
👍 @allroundexperts . I didn’t mean to sound harsh but also didn’t come up with an easy/good way to soften the language.
@parasharrajat PR ready. https://github.com/Expensify/App/pull/15262
@tienifr, Respectfully I disagree. It’s not an implementation detail that can be refined later. It’s an important piece without which the solution DOES not work unlike the addition of hash which IMO is more of an optional thing.
thanks @allroundexperts, that’s more of an implementation detail that could be refined later, also it doesn’t affect the proposal history since it already comes after yours 👍
@allroundexperts If there’s any major change to your solution (like adding the missing
window.location.hash), I’d suggest to post an updated proposal rather than editing the proposal inline so the proposal history is more clear, especially if there’s already a proposal that mentions it before 👍