App: [HOLD for payment 2022-10-20] [$250] Ensure the page not found error message is properly centered in the chat view
Problem
In this PR https://github.com/Expensify/App/pull/10452 we’ve started using the FullPageNotFoundView component in the chat view. Seems the component is not quite centered:

Solution
Investigate why (either due to the header or because the centering is optimized for the sidebar) and fix it
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 18 (12 by maintainers)
@dhairyasenjaliya proposal looks good, props for testing on all platforms and all occurrences of
FullPageNotFoundViewthroughout the appcc: @sketchydroide 🎀👀🎀 C+ reviewed!
Proposal
Cause
Fix
<BlockingView/>we need to add paddingBottom same height as HeaderWithCloseButton height<View>component we need to addpaddingBottom: variables.contentHeaderHeight<FullPageNotFoundView/>is inside the drawer has also same align issue)https://github.com/Expensify/App/blob/607f8e936a28a774a600c2185d66da5d9479e88c/src/components/BlockingViews/FullPageNotFoundView.js#L58-L64
Result
Web
M-web
iPhone
Drawer
With Fix
Without fix (current code)
I think https://github.com/Expensify/App/pull/10452 contains the necessary steps
will create PR soon 😃
sorry, assigned the wrong person initially, fixed that now, thanks @eVoloshchak, assgined @dhairyasenjaliya