App: [HOLD for payment 2022-05-23] [$250] Validate password complexity in the front end
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Sign in with a password that is too short
Expected Result:
- Error message is shown and we do not call
Authenticatecommand
Actual Result:
- Authenticate command is called and error message is shown
Workaround:
Yes
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Job Post https://www.upwork.com/jobs/~01b4cd92ce29d9f69c
IMPORTANT
Our password complexity check is in use here we’re just not using it for sign in
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 19 (8 by maintainers)
hm sorry about that @mananjadhav , I added you back in case we need a C+ for review.
@thesahindia I sent an offer for the job in Upwork, please accept when you get a chance.
Looks good to me! @kevinksullivan Can you spin up something in Upwork for this and hire @thesahindia?
Yeah, I think
passwordForm.error.incorrectLoginOrPasswordis fine to use for now.Hired ya @mananjadhav , let us know when you accept Paid @thesahindia $250 for the fix,
@thesahindia Care to put a quick proposal together for this?