App: [HOLD for payment 2022-05-23] [$250] Update default avatar and empty state text for #%domain% default room

Also thanks for noting that this doesn’t need to be on hold anymore - and I agree @Puneet-here 's proposals looks solid, hiring! 👍

Paid @Puneet-here and @rushatgabhane $250 ea for the fix and C+. Thanks for the help!

Great question @Puneet-here - I don’t know of any off the top of my head, but please ask your question in #expensify-open-source because I’m sure other contributors are wondering the same thing.

If there aren’t any test accounts for you to use, feel free to create the PR with your changes and I will test

Thanks @mallenexpensify , sorry about the delay, was OOO.

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/8898

If no regressions arise, payment will be issued on 2022-05-23. 🎊

@Puneet-here yes please, sorry for the delayed response

@Puneet-here sorry for the delay, I tagged a few more people in the Slack thread, people who were involved in the initial convo so let’s see what they say 👍

I didn’t get any reply on slack for translation so I have pushed the thread again on channel.

@Beamanator, I have asked for the translation here

At user created room we use Collaboration starts here! 🎉 as the first line, at announce room we use Collaboration between all ${workspaceName} members starts here! 🎉

instead of using Collaboration with everyone at %domain% starts here! should I just use the existing one for the first line? I think we can use Collaboration starts here! 🎉 as the first line https://github.com/Expensify/App/blob/8fae5e8c1adf0c2c1b6bae84cb1c979140fe6465/src/languages/en.js#L182

@Puneet-here Yes please feel free to ask for those translations in slack 😄 👍

Yeah I agree with @rushatgabhane - @Puneet-here can you please create a PR? I will test since this seems like a pretty small change 😄

@Puneet-here maybe raise a PR and someone internal/ QA can test it out?

I have a domain, but I’m clueless on how to create a domain chat room.

Thank you. I will raise a PR soon.

@Beamanator we can now remove the HOLD because we’ve reached a resolution - move forward with this issue using the regular split text approach.

{
    myMessagePart1: 'yadayada',
    myMessagePart2: 'yadayada',
}

Then go back and refactor once we settle on a better approach.

@kevinksullivan / @JmillsExpensify we’re putting this on hold b/c the solution for this issue will be very very similar to how we’ll fix these two issues:

• https://github.com/Expensify/App/issues/7625
• https://github.com/Expensify/App/issues/8272

@Beamanator I think it’s a good idea to hold this issue until PR https://github.com/Expensify/App/pull/8239#issuecomment-1076780473 is merged. Because we might wanna use RenderHTML to tidy it up a bit.

That’s a fair point, I’m cool with the globe in the first image.

@kevinksullivan this svg should be all you need for the new room icon asset: domain-room.svg.zip

I could see something like a globe working for domain? Quick search for “domain” on Noun Project: