App: [Awaiting payment][$500] HIGH: Add possibility to leave from the workspaces
Problem:
Right now there are no possibilities to leave from the workspace chats or from the workspace itself. The only possible solution its to be removed fully from the workspace. But there should be a possibility for members to remove themself(leave) from the workspaces.
Solution:
As discussed in the main issue, we would like to add this possibility to leave workspaces.
- For all members except
[Admin, Creator]we need to add a Leave button from the workspace chats in the similar way as we are doing Invite/Remove - Also all members(also creators) should be able to leave from workspace rooms except:
[#admin, #announce]rooms. - Please follow the rules mentioned in this issue
Additional details for workspace chat:
- Each member is added automatically to their own workspace chat, which means members cannot be removed from their own worksapce chats
- Each admin is added automatically to all workspace chats, which means that admins cannot be removed from any workspace chat
- Anybody else can be freely added to a workspace chat via invite or mention, meaning they can also be freely removed either by themselves, or by admins
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ed8483924412de03
- Upwork Job ID: 1777598308702314496
- Last Price Increase: 2024-04-09
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 50 (39 by maintainers)
Thanks @rayane-djouah , I think this might have been because the
Buglabel wasn’t applied. I’ve manually updated the job to $500. Please keep tagging me if you see any issues that aren’t auto-updating.@MitchExpensify can you manage as the BZ plz? PR is in the works
assigning @rayane-djouah as a C+
PR on production https://github.com/Expensify/App/pull/35671#issuecomment-2069764801 Deployed on 4/22
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Thanks for thorough testing on the PR. I vote for the request 👍
Thank you!
Actively working on the PR - https://github.com/Expensify/App/pull/35671.
@rezkiy37 the new API command -
LeavePolicyis now on staging API!Both backend PR’s are merged. A deploy later today will make LeavePolicy command live on staging. cc @rezkiy37
I am going to be OOO soon. Please reassign new C+ when needed.
Automated tests on one of my PR are failing because in oldDot, only admins have an option to leave the workspace. Instead of adding an exception to code, and follow our 1:1:1 ideology, I am going to split up the command, have a new command to leave workspace
I have got PR’s up!
@rezkiy37 Enjoy your time off!
Hey! I must inform you that I have a vacation next week. I will be back on Monday 25.03. During the vacation, someone from Callstack can take the issue to work. See you soon!
Thanks for resolving conflicts! I am working on PR’s. We would need 2. Would try to get them in review before I logout
Yes, this PR. Let me sync it up with the
main.I’ll take a look this week
I’ll circle back to this
Added to release 1.