App: [Awaiting Payment][$250] Migrate BaseKYCWall.js to function component

Class Component Migration

Filenames

src/components/KYCWall/BaseKYCWall.js
- type: React.Component
- has state values: true
- has refs: false
- has context: false
- lifecycle methods: componentDidMount,componentWillUnmount

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here’s a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017c04af1c1cb9169b
Upwork Job ID: 1709215451872694272
Last Price Increase: 2023-10-03
Automatic offers:

abdulrahuman5196 | Reviewer | 27683790

Issue Owner

Current Issue Owner: @kadiealexander

About this issue

Original URL
State: closed
Created a year ago
Comments: 45 (30 by maintainers)

Most upvoted comments

Thanks @bondydaa yeah. It’s due for payment. @kadiealexander

abdulrahuman5196 on Dec 15, 2023

The revert was b/c of a crash that was happening, let me know if you can’t see this thread https://expensify.slack.com/archives/C049HHMV9SM/p1697838755135299?thread_ts=1697694190.199399&cid=C049HHMV9SM

the first part of that thread was something different starting from where Matt chimes in and posts videos is the portion that concerns why we reverted the PR.

but steps were:

I’m still getting a crash on login on staging and the PR for/from here already hit staging.

Log in

App crashes or… try to navigate from a report link to staging.new.expensify.com and it crashes or… more reliable repro steps from my mallen@expensifail.com account, try to open mallen@expensify.com to chat with. Happening on Mac - Chrome and Windows - Chrome (via browserstack)

So I think it was just upon sign in.

Looks like this was initially suggested as a fix for the crash before we reverted https://github.com/Expensify/App/issues/30109#issuecomment-1773470364

bondydaa on Nov 16, 2023

Great thank you Eto!

bondydaa on Nov 15, 2023

@kadiealexander @Swor71 is from expert groups so no payment here.

Moreover the issue is not fixed. The PR got reverted for another issue. @Swor71 Can you create the PR to merge?

abdulrahuman5196 on Oct 30, 2023

Just to share more widely here as well, I hastily merged the PR not realizing we had money2020 starting this weekend and it caused crashes on staging (see https://github.com/Expensify/App/issues/30109#issuecomment-1773470364)

so I reverted on here https://github.com/Expensify/App/pull/30110.

To re-apply the changes on https://github.com/Expensify/App/pull/28798 we can “revert the revert” pr https://github.com/Expensify/App/pull/30110 or just redo the work of https://github.com/Expensify/App/pull/28798 on a fresh git checkout -b main both should be fine.

If reverting the revert just make sure the line Wallet.setKYCWallSourceChatReportID(chatReportID); is removed since it was removed in this PR https://github.com/Expensify/App/pull/29573

bondydaa on Oct 20, 2023

Sorry folks. I think already @Swor71 is assigned to work on this issue

abdulrahuman5196 on Oct 3, 2023