App: [Awaiting Payment 23rd April] [$250] Deprecate `policy.role` in favor of `employeeList`
From this internal conversation, we want to deprecate policy.role in favor of employeeList to check the current user’s role:
As a summary, I think ideally what we need to make happen is:
1. Update App so it fetches a policy role in the correct place (using employeeList, not top-level role which does not exist in the database)
2. Undo sending the role top-level policy attribute to Onyx
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d08fbf19a9080a89
- Upwork Job ID: 1782708664427339776
- Last Price Increase: 2024-04-23
- Automatic offers:
- shubham1206agra | Reviewer | 0
- getusha | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Reactions: 1
- Comments: 33 (24 by maintainers)
PR is up https://github.com/Expensify/App/pull/40178 But we should hold this for https://github.com/Expensify/App/pull/39489
I will raise a PR tomorrow. Approximately 20 small changes are there.
Ok, we’d need to deprecate
policy.rolefirst from the frontend in favor of employeeList and then remove all thepolicy.roleinstances from Auth. Looking for a contributor to help with the first partRemoving the hold from the title then! Marco is out until Monday, so hopefully we can pick it up then.