App: [Awaiting Payment 23rd April] [$250] Account Settings - When legal name change there is not reflect in other device
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.59-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): alexzamora1487+01042024@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team
Action Performed:
- On deviceA go to settings > profile > personal details > legal first name
- Enter a name that’s 100+ characters long i.e
gfkfkfkfkfkfkkfkfkfkfkfkfkfkfkfkffkkfkgkgkgkkgkgkgkgkgkgkgkgkgkgkgkgkgkgkgkgkgkgkgkgkkgkgkgkgkgkkggkk - Observe the error that the 100 character field length is exceeded
- Now enter a name that’s 10 characters long i.e
gkgkgkgkgk - Switch to deviceB, observe that the legal first name updates
- On deviceA, enter a name that’s 41 characters long i.e
gfkfkfkfkfkfkkfkfkfkfkfkfkfkfkfkffkkfkfka - Switch to device B, observe that the legal first name doesn’t update
- On deviceA, enter a name that’s 40 characters long. i.e
gfkfkfkfkfkfkkfkfkfkfkfkfkfkfkfkffkkfkfk - On deviceB, observe that the legal first name does update.
Expected Result:
The frontend and backend character limit for the legal name field should be the same. Let’s update the character limit on the front-end to 40 to match the backend.
Actual Result:
The frontend character field limit is 100, but the backend character limit is 40 characters. As a result, there’s no error being displayed on the front-end when someone enters a value of 40+ characters and it doesn’t get saved either.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/a0e95ad1-fe85-418f-b2d9-fb4a12674d13
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Comments: 43 (31 by maintainers)
I was able to confirm in the marqeta docs that the last name character limit is 40 as well - docs.
So yeah front end should be updated to match this.
PR ready for review . c.c. @parasharrajat
Sounds good! When I’d investigated a lot of the field length limits previously, we had just picked a number we thought made sense for a lot of them. But def curious to here if there was a specific reason for the 40 for this one. If there was, totally fine with me to stick with that too.
only one of my PR’s is active, 14 have been merged 😃, so i think it would be unfair not to assign @parasharrajat 😃
Those issues are due payment, PR’s were merged and deployed to production 😃
Can you please reconsider the assignment, thanks
c.c. @chiragsalian
@trjExpensify is there a reason we wouldn’t update the BE to match the FE limit of 100? There’s no hard and fast rule here, but 100 for a field like this is the standard we had landed on. So unless there’s some specific benefit to 40, I feel like it could make sense to standardize on 100 personally.
I am confirming the requirements before reviewing the proposals.