App: [aimane-chnaif please complete] [HOLD for payment 2023-07-26] [$1000] Web - The user added to workspace can see invite page but can't add the members

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. User A - Create a workspace and add user B
  2. Now go to workspace’s invite member page, copy the url after the base - something like - /workspace/<workspace id>/invite
  3. Now go to different browser where user B is logged in.
  4. Append the copied part to url after the base urls, ex - https://staging.new.expensify.com/workspace/<workspace id>/invite
  5. Notice the User B can see the invite page
  6. Try inviting a user to the workspace by following the workflow

Expected Result:

If user doesn’t have permission to invite new members to workspace, the page should provide the error message

Actual Result:

User can see the invite page and can invite the user but after adding gives the error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.34-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/1bbea3b8-510d-4e11-8b5f-3eb1a1e14f59

https://github.com/Expensify/App/assets/93399543/4b32996b-6632-4d13-9ed9-4132900790cf

Expensify/Expensify Issue URL: Issue reported by: @BhuvaneshPatil Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688059822067529

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0148a57d74a819953e
  • Upwork Job ID: 1676321039486058496
  • Last Price Increase: 2023-07-04

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 35 (19 by maintainers)

Most upvoted comments

@BhuvaneshPatil report, fix, bonus ($1750) - paid ✔️ @aimane-chnaif review, bonus ($1500) - paid ✔️

@aimane-chnaif Here are my findings -

  1. WorkspaceMembersPage
  2. WorkspaceInvitePage
  3. WorkspaceInviteMessagePage
  4. ReimbursementAccountPage https://github.com/Expensify/App/blob/401b4595911afb27bb67144a59e263c08cf352e5/src/pages/ReimbursementAccount/ReimbursementAccountPage.js#L333-L343

We can add conditions here, to check if the current user is policy owner.

I have tried going every route related to workspace, this is how much I could find out. Will keep you posted here.

@BhuvaneshPatil can you please list all workspace pages which have this issue?