App: [Actionable System Messages] [$500] [MEDIUM] Workspace Chats: We’re doubling up on the “submitted” reportAction on the report

Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1703187600061979?thread_ts=1703187017.215259&cid=C02MW39LT9N

Action Performed:

Action steps:

Pre-testing requirement: Collect workspace type with the isPolicyExpenseChatEnabled NVP set (SO).

  1. Sign-in for the first time using the member account • Verify that you land in the workspace chat
  2. Go to global create (+) > Request money > enter an amount > confirm
  3. Tap the report preview component to navigate to the expense report view • Verify that a banner at the top of the page reads "Waiting for [Admin name] to Approve these expenses • Verify that a note exists showing that the submitter has submitted the expenses "[Employee Name] submitted [Amount] • Verify a “You submitted this report to [Admin Name][Admin email]” message at the bottom of the page

NOTE: If you change the Scheduled Submit Frequency the wording mentioned above does not fit.

  1. As the admin, go to OldDot and change the scheduled submit frequency to manually for a workspace
  2. Log back into NewDot as the member (or refresh if you already are in another window) • Verify that the LHN row for the workspace chat includes a GBR green dot for the draft report awaiting submission ✅
  3. Tap the workspace chat row to navigate to the workspace chat view • Verify that the draft report preview component appears in the workspace chat ✅ • Verify that the draft report preview component in the chat:
  4. Includes a green Submit button ✅
  5. Tap the report preview component of the second draft report to navigate to the expense report view • Verify that a banner is in the page header with the label Next steps doesn’t include a Submit button ❌ • Verify that the next steps text matches the manual submission cadence you set on the paid policy. E.g “Waiting for %displayName% to submit expenses.” ❌ • Verify that a green Submit button is in the page header beneath the “Next steps” banner ❌

Expected Result:

  • We’re doubling up on the “submitted” reportAction on the report - we don’t need both notifications that the expense is submitted

Actual Result:

  • multiple indications that a report has been submitted

Screenshots/Videos

image

View all open jobs on GitHub

cc @cristipaval @garrettmknight

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01be4453255ad088f0
  • Upwork Job ID: 1742263089109061632
  • Last Price Increase: 2024-01-16
Issue OwnerCurrent Issue Owner: @youssef-lr

About this issue

  • Original URL
  • State: closed
  • Created 6 months ago
  • Comments: 48 (30 by maintainers)

Most upvoted comments