App: [$500] The bold markdown text entered after a codeblock text in the composer does not render correctly as bolded
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.54-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710548240738149
Action Performed:
- Open any report
- Compose a multiline message with bold and codeblock
‘’ bold
*not a bold*
This is * bold * "
Expected Result:
Should render
bold
*not a bold*
This is bold
Actual Result:
bold
*not a bold*
This is bold
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/62b3c27f-595d-4146-a7bf-aa33cdc3cf0f
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01835d45018b65a8ed
- Upwork Job ID: 1770178926683250688
- Last Price Increase: 2024-04-09
- Automatic offers:
- fedirjh | Reviewer | 0
- tienifr | Contributor | 0
About this issue
- Original URL
- State: open
- Created 3 months ago
- Comments: 39 (27 by maintainers)
PR is merged - @tienifr thoughts on the above?
@fedirjh PR https://github.com/Expensify/expensify-common/pull/681 is ready to review
Thank you @tienifr for the feedback. I believe we can move forward with your proposal. Based on comments in https://github.com/Expensify/App/issues/38522#issuecomment-2035099779 and https://github.com/Expensify/App/issues/38522#issuecomment-2045598463, It appears that your proposal is working as expected.
Let’s move forward with this proposal from @tienifr.
🎀 👀 🎀 C+ reviewed
@fedirjh The bold should match even when there’re line breaks, this is by design IMO, here’s the test case in
expensify-common
that protects this case.I’ll post an update on this tomorrow 👍