App: [$500] IOU - Approve button appears while approvals is disabled
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.57-2 Reproducible in staging?: Y Reproducible in production?: Y Found when executing PR : https://github.com/Expensify/App/pull/38253 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team
Action Performed:
Pre-requisites: Have a collect WS and make chat enabled on ND Have 2 accounts (one admin, one employee) Having `Make or track payments enabled Toggle on delay submissions on ND (Logged in as the admin) Toggle off Add approvals On OD Make reimbursement direct with a VBBA
- [Employee] Request money from the workspace chat and submit it
- [Admin] Click on the IOU preview and observe the header
Expected Result:
“Pay with expensify” button should show up since this is the case where Delay submissions is enabled and approvals is disabled
Actual Result:
“Approve” button appears on the header
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/4c0144dc-f6e3-4455-9c33-2db66596918b
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014fc34bb4b2bfbb10
- Upwork Job ID: 1773511332097155072
- Last Price Increase: 2024-03-29
About this issue
- Original URL
- State: closed
- Created 3 months ago
- Comments: 24 (17 by maintainers)
We should not show the approve button if approvals are disabled
I tentatively think that definitely makes sense 😅 👍