App: [$500] iOS - Inconsistent translation for accessibilityLabel of Floating Action Button

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Turn on “voice over” in your IOS device.
  2. Long press or press Fab button.
  3. Notice that it sounds “'New chat (Floating action)”
  4. Change language to Spanish, long press or press Fab button.
  5. Notice that it sounds “'Nuevo chat”. There’s more simpler way to find it, we can search for accessibilityLabel in our en.js and es.js in out source code.

Expected Result:

AccessibilityLabel of Fab button in Spanish should be “Nuevo chat (Acción flotante)”

Actual Result:

AccessibilityLabel of Fab button in Spanish is “Nuevo chat” which is inconsistent with English.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.56-18

Reproducible in staging?: Needs reproduction

Reproducible in production?: Needs reproduction

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshot 2023-08-23 at 13 36 11 Screenshot 2023-08-23 at 13 36 18

Expensify/Expensify Issue URL:

Issue reported by: @hungvu193

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692772548251279

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190d81f792e377c25
  • Upwork Job ID: 1701237346978205696
  • Last Price Increase: 2023-09-25
  • Automatic offers:
    • hungvu193 | Reporter | 26876528

About this issue

  • Original URL
  • State: closed
  • Created 10 months ago
  • Comments: 37 (13 by maintainers)

Most upvoted comments

Proposal from @hungvu193

Please re-state the problem that we are trying to solve in this issue.

Inconsistent translation for accessibilityLabel of Floating Action Button

What is the root cause of that problem?

We’re using different word for fabNewChat with English and Spanish here, which make it inconsistency

https://github.com/Expensify/App/blob/4f412db5e26782740529eb0ef17b5db157628413/src/languages/en.js#L364

https://github.com/Expensify/App/blob/4f412db5e26782740529eb0ef17b5db157628413/src/languages/es.js#L363

What changes do you think we should make in order to solve the problem?

We should change the translation of fabNewChat here to:

Nuevo chat (Acción flotante)

What alternative solutions did you explore? (Optional)

We can change the translation of fabNewChat here to:

New chat