App: [$250] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js

This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestDatePage New Component IOURequestStepDate

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0155d041c50cef598e
Upwork Job ID: 1747632794805731328
Last Price Increase: 2024-01-24
Automatic offers:

DylanDylann | Contributor | 28130672
brunovjk | Contributor | 28132561

About this issue

Original URL
State: closed
Created 5 months ago
Comments: 39 (25 by maintainers)

Most upvoted comments

All paid up

muttmuure on Feb 27, 2024

@brunovjk I think these changes also need to be included in your PR:

Remove IOU.setMoneyRequestCreated() and all references
Rename IOU.setMoneyRequestCreated_temporaryForRefactor() to IOU.setMoneyRequestCreated()

tgolen on Jan 31, 2024

@muttmuure The PR was deployed to production 5 days ago. It seems the automation bot doesn’t work on this issue. Please help to move forward this one

DylanDylann on Feb 20, 2024

As I know MoneyRequestView.tsx is only used for REQUEST flow, and isn’t used in SPLIT_BILL flow. It is the reason why I hardcoded CONST.IOU.TYPE.REQUEST

DylanDylann on Feb 5, 2024

@brunovjk Please raise a PR soon

DylanDylann on Feb 5, 2024

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] on Jan 31, 2024

@brunovjk Please wait to be assigned official before implementing PR

DylanDylann on Jan 31, 2024

It looks like you copied the link to my proposal wrong hehe

Thanks. Updated 😄

DylanDylann on Jan 31, 2024

Discussed here about the fully expectation

@brunovjk’s proposal cover all cases. Let’s go with them

🎀 👀 🎀 C+ reviewed

DylanDylann on Jan 31, 2024