App: [$250] Remove `Add receipt` from the three dot overflow menu
Problem
We’ve recently added a receipt empty state in conjunction with the on-going violations project, though we also have an existing Add receipt option in the three dot overflow menu. Example below.
Accordingly, we effectively have two options to do the same thing, within the same screen. That’s confusing and unnecessary.
Solution
Let’s remove the Add receipt option in the three dot overflow menu, such that the receipt empty state is the only/main flow for adding receipts.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01462cd7dc3ef5fb51
- Upwork Job ID: 1760460411785555968
- Last Price Increase: 2024-02-22
- Automatic offers:
- s77rt | Reviewer | 0
- Krishna2323 | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 4 months ago
- Comments: 36 (18 by maintainers)
Payment summary:
All contracts paid. Given that we are removing functionality, I don’t think we need to create a regression test for this case.
That sounds good to me, and we can remove the beta check for violations that we currently have for display the receipt empty state https://github.com/Expensify/App/blob/8783eb45a57e648d63cdaa5529b7c060e419576c/src/components/ReportActionItem/MoneyRequestView.tsx#L275-L276
Not sure why the automation failed, though please reach out to me via DM for these cases. I’m on hundreds of issues so it’s hard to keep track.
@s77rt PR ready for review.
Yes, violations are still being implemented and under a beta. In fact, this is what has created the duplicate flows to do the same thing. So we want to remove
Add receiptfrom the overflow menu as we’re cleaning up this overall flow.P.S. I also reached out to Carlos via DM to confirm he’s aligned.