App: [$250] [Group Chats] [Polish] Move "Leave" button into a row of the Report Details page

Here is a better mockup to reference:

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

PR will be ready tomorrow

I think this conversation could be taking a bit of an unproductive turn. I have the following thoughts:

• We will assign @ZhenjaHorbach here. It’s the C+ who should recommend someone. I don’t feel the need to go against that decision. C+ need to be able to operate with some autonomy here and should be following our rules.
• I don’t think this ticket is particularly complex and don’t quite feel like anyone is more or less qualified to do it (at least not based on what I can see in this issue). My priority is always to have people work together to implement the best solution.
• @dragnoir an option for you could be to prepare some kind of claim that says “I materially contributed x, y, z to this issue” and reach out to the contributor email. Compensation requests for contributors who go above and beyond are pretty typical around here. We have a history of retaining and rewarding people who help us out. We also have some pretty clear language in the contributing guidelines about all of this IIRC so please review them again at your leisure.

@ZhenjaHorbach you didn’t respect the contribution rules. It’s made to eliminate the behavior of people trying to quickly post a brief not detailed proposal just to win the 1st place and then edit it many times.

as you can see after the second proposal was posted I stopped editing my proposal Although I still had ideas on how to improve it

And in my original proposal I already provided links to components that need to be changes The remaining changes were related to technical implementation Which in most cases is optional

But anyway Maybe I’m wrong and I did something bad So let’s wait for the decision

And thank you for your opinion

@DylanDylann another thing you should consider please: @ZhenjaHorbach broke the contributions rules.

as you can see on the screenshots, he edited his proposal many times without any mentions. And this is against our contribution rules.

If you want to make an entirely new proposal or update an existing proposal, please go back and edit your original proposal, then post a new comment to the issue in this format to alert everyone that it has been updated:

We discussed this on Slack many times and this behavior should be stopped.

In the room detail page we will display leave and pin option

This is probably just a mistake from our Figma files. We want leave to always be a row at the bottom of the option rows, it would never be a button in the horizontal button stack.

@dragnoir we should confirm requirements clearly before updating the proposal to save effort 😄

@dragnoir same as the other issue, but posting here for posterity:

Figma link

@DylanDylann

whether the avatar should be displayed larger

I think we can ignore the avatar for the purposes of this issue. We’re focusing on the “Leave” + “Share” actions in this ticket.

Do we also display the ChatDetailsQuickActionsBar for the room report

We did this largely to focus the introduction of this behavior and allow testing it for Group Chats in isolation. But I think ideally we would take this opportunity to standardize the UI for this. What do you think @JmillsExpensify?

Since the “Leave” action is the only one with a behavior specific to Group Chats - we should be able to show this for Rooms as well. But we can investigate as part of this issue to make sure that assumption is correct.

Taking over as C+ role