App: [$250] Group Chat - View scrolls to Recents header when unselecting users from group conversation

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found during executing PR https://github.com/Expensify/App/pull/9798

Action Performed:

Go to staging.new.expensifail.com
Log in with any use
Tap on Fub menu
Tab Group Chat
Scroll and select the user
Select a couple more users
Unselect one of the user from the list

Expected Result:

View does not scroll after unselecting a user from a group conversation

Actual Result:

View scrolls down to the Recents header (hiding currently selected users) after unselecting a user from a group conversation

Workaround:

Yes, they can scroll up to see the users again

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.84.11

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/179050372-edb3c97a-9f9b-4987-b62c-96ca998a441f.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 42 (32 by maintainers)

Most upvoted comments

PR merged

roryabraham on Aug 2, 2022

Yep, lets pay this out now

roryabraham on Sep 2, 2022

Upwork profile - https://www.upwork.com/freelancers/~01921c050b587a3859

jeet-dhandha on Jul 28, 2022

While I think @jeet-dhandha’s solution is equivalent, let’s just go with the solution I laid out above.

roryabraham on Jul 27, 2022

Proposal

Setting Focused Index to default “0” fixes the issue. And also we are focusing 0th index and 0th sectionIndex, on each user select.

(Note: The above issue is also reproducible on Android Build also.)

Fixed App Video (Android):

https://user-images.githubusercontent.com/78416198/179458789-598e4e29-94f5-44d1-bdaa-e8a2fc44dbe1.mp4

Fixed App Video (Web):

https://user-images.githubusercontent.com/78416198/179458828-5ec90921-d6a7-42b0-9de8-f8a6da415577.mp4

jeet-dhandha on Jul 18, 2022

I’ll sign on as CME here since I’m very familiar with this code

roryabraham on Jul 15, 2022

Ah, @kbecciv, I see! The issue is that it scrolls down to the Recents heading when you select a user instead of staying at the currently selected user’s section. I’ve updated the issue to make that a bit clearer.

This looks good for a contributor to pick up. Marking as external. cc: @roryabraham though just cause it seems like it might be tied to the OptionsSelector (and focusedIndex) logic that was changed recently.

NikkiWines on Jul 15, 2022