App: [$250] Android - Room-Tapping create room with specific description directs to concierge page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.52 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4426548 Issue reported by: Applause - Internal Team

Action Performed:

Launch app
Tap fab-- start chat — Room
Enter room name
Paste the below text in room description

we can close this to focus on more urgent issue this is just a minor viewing discrepancy

~can close this to focus on more urgent issue this is just a minor viewing discrepancy~

can close this to focus on more urgent issue this is just a minor viewing discrepancy

can close this to focus on more urgent issue this is just a minor viewing discrepancy

Tap create room

Expected Result:

When user taps create room, he must be directed to room page and must not be redirected to concierge page

Actual Result:

When user taps create room with specific text entered in room description. , he is directed to room page but within seconds redirected to concierge page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/3cceba5d-cd92-47c7-bd7c-eb43e0279f33

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0171e588018217e1f4
Upwork Job ID: 1772221395416739840
Last Price Increase: 2024-04-01
Automatic offers:

shubham1206agra | Reviewer | 0
rmm-fl | Contributor | 0

About this issue

Original URL
State: open
Created 4 months ago
Comments: 32 (20 by maintainers)

Most upvoted comments

@jasperhuangg Can you do the assignment here?

shubham1206agra on Apr 8, 2024

Bump @jasperhuangg on confirming contributor selection above 😃

greg-schroeder on Apr 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

create room with specific description directs to concierge page

What is the root cause of that problem?

Server returns description too long error

What changes do you think we should make in order to solve the problem?

Because the server checks the final html generated length, instead of markdown, we should use the same final html generated string length for validation. Validation step doesn’t check for description length, we should add length validation here:

https://github.com/Expensify/App/blob/0a512c9f3cf1b207668ab93f3d79866c80345f88/src/pages/workspace/WorkspaceNewRoomPage.tsx#L163-L181

Solution

const descriptionLength = ReportUtils.getCommentLength(values.reportDescription);
if (descriptionLength > CONST.DESCRIPTION_LIMIT) {
    ErrorUtils.addErrorMessage(errors, 'reportDescription', ['common.error.characterLimitExceedCounter', {length: descriptionLength, limit: CONST.DESCRIPTION_LIMIT}]);
}

What alternative solutions did you explore? (Optional)

rmm-fl on Mar 15, 2024