App: [$1000] Share code - Unable to go to the chat with a user whose email address has "+"

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR https://github.com/Expensify/App/pull/18636

Action Performed:

  1. Log into an account that has a + in the email, ex: example.user+test@applause.expensifail.com
  2. Go to URL https://staging.new.expensify.com/
  3. Go to Settings > Share code
  4. Using another phone, scan the QR code on the page and verify that it takes you to New Dot to view the profile page of the user
  5. Tap Massage example.user+test@applause.expensifail.com

Expected Result:

User can jump to a conversation with another user using a QR code.

Actual Result:

The user sees an error in the chat and is not able to send messages.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.14.9

Reproducible in staging?: Yes

Reproducible in production?: new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/aa3087c4-bea4-4347-89fb-d7fd2f045427

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team @nathan-mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684165146584739

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01efcc2d2440f70193
  • Upwork Job ID: 1660658319748927488
  • Last Price Increase: 2023-05-22

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 17 (8 by maintainers)

Most upvoted comments

Reopening this so we can pay @Nathan-Mulugeta for reporting the issue once https://github.com/Expensify/App/pull/19249 is deployed (as discussed starting here). (cc @michaelhaxhiu)

This was already fixed in https://github.com/Expensify/App/pull/19249, this was a duplicate issue we didn’t realize.

Whops, I didn’t notice the + requirement, thanks for the correction, trying it now with an email address that has a +