App: [$1000] Provide reasonable defaults for all instances where we try to access a parent report that doesn't exist

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.79-3 Reproducible in staging?: yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: N/A

Action Performed:

  1. As accountA, mention accountB in a thread in a room that they don’t have access to.
  2. As accountB, try to open that thread.
  3. Notice the app crashes

Expected Result:

The App shouldn’t crash, and you should be able to view the thread.

Actual Result:

The App crashes because the parentReport is undefined here. We need to provide a reasonable default so that doesn’t happen.

We should also search the codebase for any other instances where we may be accessing a parentReport that’s undefined and fix those as well. A good proposal will find other instances where this may happen.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/31285285/867afbd8-2cd6-4e34-b1d5-ba807b0e1581

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0199b3acca3ca06afe
  • Upwork Job ID: 1711432848480976896
  • Last Price Increase: 2023-10-16

About this issue

  • Original URL
  • State: closed
  • Created 9 months ago
  • Comments: 16 (8 by maintainers)

Most upvoted comments

@jasperhuangg @puneetlath this looks like a simple update, do you agree, and would it make sense to decrease the bounty to $250?