App: [$1000] Extra space around text in header of reply in thread if main message has 3 backtick code block
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app
- Open any report
- Send message with 3 backtick code block in it eg: hi
hellotest - Hover and click on reply in thread
- Observe the header text, it will have extra spaces around text which was 3 backtick code block
Expected Result:
Format of text should not affect reply in thread header text formatting
Actual Result:
3 backtick code blocks in text adds extra space around the text in reply in thread header
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.39-10 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/9fcbc3fe-9ffc-41f8-9e6b-392f590c928f
https://github.com/Expensify/App/assets/93399543/c660f0df-1a06-48fb-8a80-2b2aa565d65b
Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689183843669479
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010cf4dbd8dbc4da67
- Upwork Job ID: 1684257620704722944
- Last Price Increase: 2023-08-09
- Automatic offers:
- tienifr | Contributor | 26112867
- dhanashree-sawant | Reporter | 26112869
Issue Owner
Current Issue Owner: @tienifrAbout this issue
- Original URL
- State: open
- Created a year ago
- Comments: 114 (85 by maintainers)
I will update today.
@sobitneupane I confirmed in Slack that we want the markdown to always display as markdown. Our design should be that you see the exact message in the header that you created.
Regarding # highlighted it was mentioned that it isn’t an officially supported markdown feature. It’s actually some shortcut for doing another hidden action in the app. So we should ignore the markdown in this case. The one exception would be
# highlightedSo going back to your examples:
# highlightedis the markdown for highlighted text shown below.On the thread header this should display as “highlighted” without any markdown.
On the thread header this should display as
Does this make more sense now? Any other questions?
Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!
Back to you @flaviadefaria as I’m off this week, thx
This makes sense to me.
@sobitneupane @flaviadefaria Do you think we need to get more eyes on the code fence case? Increase header height does not sound great to me. IMO, we should render code fence as inline code in this case.
Code fence:
Inline code:
Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Hmm you’re raising some good examples @sobitneupane. Let me quickly take this back to Slack as my view personally was that we didn’t display markdown in the thread title but others thought differently, so I want to double-check.
Or just display the first line without the ending backticks, like
```line1@flaviadefaria After going through the above proposals, I am pretty sure most of us are not clear about the expected output.
So, bo be clear on the expected output:
If we have highlighted text as the message, what will be the header.
# highlighted texthighlighted text
If we have following code block as the message, what will be the header.