App: [$1000] Do not update IOU total when IOU requests are submitted offline and the currency differs from the iouReport currency

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Request money from a user in USD, + > Request money
  2. Go offline
  3. Send another money request, but this time set a different currency, e.g. AED
  4. Notice that the IOU preview just sums up the amount in USD and AED, without considering the exchange rate so the USD total displayed is incorrect
  5. Go online and notice that the total is updated to the correct USD amount

https://user-images.githubusercontent.com/22219519/199781387-6e0356c0-7edc-49dc-8392-7a7cb2470403.mov

Expected Result:

  1. Coming from this thread, we decided that the total amount should not be updated if offline requests are submitted in a currency that is different than the currency on the iou report.
  2. Additionally, if the iouReport has requests in different currencies and the user is offline, we should disable the Pay button cc @youssef-lr @sketchydroide since you are working on the Pay IOU flow refactors.

Actual Result:

Amount is summed up without taking the exchange rate into consideration

Workaround:

N/A

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 24 (5 by maintainers)

Most upvoted comments

Thanks for the quick work @youssef-lr!