electron-builder: Invalid Identity.Publisher in AppxManifest.xml
- Version: 20.36.2
- Target: appx
Build fails with error as below:
Error: Exit code: 1. Command failed: C:\Users\level7\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.4.0\windows-10\ia32\makeappx.exe pack /o /f C:\Users\level7\Desktop\electron-softphone\electron\dist\__appx-ia32\mapping.txt /p cae0a702dee6d01422d41f5cc1a2734c26bf688087aaf5479190f7bb2aed5f60 (sha256 hash)
Microsoft (R) MakeAppx Tool
Copyright (C) 2013 Microsoft. All rights reserved.
The path (/p) parameter is: "\\?\C:\Users\level7\Desktop\electron-softphone\electron\dist\VoIPstudio-3.0.45-ia32.appx"
The mapping file (/f) parameter is: "C:\Users\level7\Desktop\electron-softphone\electron\dist\__appx-ia32\mapping.txt"
Reading mapping file "C:\Users\level7\Desktop\electron-softphone\electron\dist\__appx-ia32\mapping.txt"
Packing 128 file(s) listed in "C:\Users\level7\Desktop\electron-softphone\electron\dist\__appx-ia32\mapping.txt" (mapping file) to "\\?\C:\Users\level7\Desktop\electron-softphone\electron\dist\VoIPstudio-3.0.45-ia32.appx" (output file name).
Memory limit defaulting to 1610377216 bytes.
Using "C:\Users\level7\Desktop\electron-softphone\electron\dist\__appx-ia32\AppxManifest.xml" as the manifest for the package.
MakeAppx : error: Error info: /*[local-name()="Package" and namespace-uri()="http://schemas.microsoft.com/appx/manifest/foundation/windows10"]/*[local-name()="Identity" and namespace-uri()="http://schemas.microsoft.com/appx/manifest/foundation/windows10"][1]/@Publisher
'CN=Level 7 Systems Ltd.,O=Level 7 Systems Ltd.,POSTALCODE=N12 0DR,STREET=2 Woodberry Grove+STREET=1st Floor,L=London,ST=Greater London,C=GB' violates pattern constraint of '(CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|Description|PostalCode|POBox|Phone|X21Address|dnQualifier|(OID\.(0|[1-9][0-9]*)(\.(0|[1-9][0-9]*))+))=(([^,+="<>#;])+|".*")(, ((CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|Description|PostalCode|POBox|Phone|X21Address|dnQualifier|(OID\.(0|[1-9][0-9]*)(\.(0|[1-9][0-9]*))+))=(([^,+="<>#;])+|".*")))*'.
The attribute 'Publisher' with value 'CN=Level 7 Systems Ltd.,O=Level 7 Systems Ltd.,POSTALCODE=N12 0DR,STREET=2 Woodberry Grove+STREET=1st Floor,L=London,ST=Greater London,C=GB' failed to parse.
MakeAppx : error: Package creation failed.
MakeAppx : error: 0x80080204 - The specified package format is not valid: The package manifest is not valid.
package.json:
{
"name": "VoIPstudio",
"repository": "http://repo.ssl7.net/repo/voipstudio/stable/main/binary",
"homepage": "https://voipstudio.com",
"version": "3.0.45",
"description": "Softphone and IM",
"main": "main.js",
"storeBuild": false,
"productCode": "v",
"appKey": "voipstudio",
"apiUrl": {
"dev": "https://api.l7dev.co.cc/v1",
"test": "https://api.l7test.co.cc/v1",
"sandbox": "https://api-sandbox.ssl7.net/v1",
"prod": "https://l7api.com/v1"
},
"updTestServer": "udptest.ssl7.net",
"scripts": {
"start": "electron . --dev",
"prod": "electron . --dev --prodapi",
"dist": "electron-builder"
},
"author": {
"name": "VoIPstudio",
"email": "info@voipstudio.com"
},
"license": "X11",
"devDependencies": {
"electron": "3.0.10",
"electron-builder": "20.36.2",
"electron-rebuild": "^1.8.2",
"electron-debug": "1.1.0"
},
"dependencies": {
"auto-launch": "5.0.5",
"bindings": "1.3.0",
"electron-log": "2.2.7",
"electron-updater": "^4.0.0",
"is-running": "2.1.0",
"keytar": "4.3.0",
"mime-types": "2.1.15",
"minimist": "0.0.8",
"node-abi": "^2.4.5",
"uuid": "3.1.0",
"ws": "^3.3.2"
},
"build": {
"appId": "com.voipstudio.app",
"publish": {
"provider": "generic",
"url": "https://repo.ssl7.net/release/voipstudio"
},
"npmRebuild": false,
"nodeGypRebuild": false,
"files": [
"!dev-host.json",
"!*.sh",
"!lib",
"!lib/*",
"!build",
"!build/*",
"!branding",
"!branding/*"
],
"mac": {
"category": "public.app-category.productivity",
"target": [
"dmg",
"zip"
],
"icon": "resources/icon/icon.icns"
},
"linux": {
"category": "Network",
"target": [
"deb"
],
"icon": "resources/icon/linux",
"extraFiles": [
{
"from": "lib/${os}/${arch}/libstdc++.so.6",
"to": "libstdc++.so.6"
},
{
"from": "lib/${os}/${arch}/libstdc++.so.6.0.21",
"to": "libstdc++.so.6.0.21"
}
]
},
"win": {
"asarUnpack": [
"compiled/10.2.0/win32/ia32/system_idle_time.node",
"node_modules/keytar/build/Release/win32/ia32/keytar.node"
],
"target": [
"nsis",
"appx"
],
"icon": "resources/icon/icon.ico"
},
"nsis": {
"oneClick": true,
"runAfterFinish": true
},
"appx": {
"publisher": "CN=Level 7 Systems Ltd."
}
}
}
AppxManifest.xml:
<?xml version="1.0" encoding="utf-8"?>
<!--suppress XmlUnusedNamespaceDeclaration -->
<Package
xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10"
xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10"
xmlns:desktop="http://schemas.microsoft.com/appx/manifest/desktop/windows10"
xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities">
<!-- use single quotes to avoid double quotes escaping in the publisher value -->
<Identity Name="VoIPstudio"
ProcessorArchitecture="x86"
Publisher='CN=Level 7 Systems Ltd.,O=Level 7 Systems Ltd.,POSTALCODE=N12 0DR,STREET=2 Woodberry Grove+STREET=1st Floor,L=London,ST=Greater London,C=GB'
Version="3.0.45.0" />
<Properties>
<DisplayName>VoIPstudio</DisplayName>
<PublisherDisplayName>VoIPstudio</PublisherDisplayName>
<Description>Softphone and IM</Description>
<Logo>assets\StoreLogo.png</Logo>
</Properties>
<Resources>
<Resource Language="en-US" />
</Resources>
<Dependencies>
<TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.14316.0" MaxVersionTested="10.0.14316.0" />
</Dependencies>
<Capabilities>
<rescap:Capability Name="runFullTrust"/>
</Capabilities>
<Applications>
<Application Id="VoIPstudio" Executable="app\VoIPstudio.exe" EntryPoint="Windows.FullTrustApplication">
<uap:VisualElements
BackgroundColor="#464646"
DisplayName="VoIPstudio"
Square150x150Logo="assets\Square150x150Logo.png"
Square44x44Logo="assets\Square44x44Logo.png"
Description="Softphone and IM">
<uap:DefaultTile Wide310x150Logo="assets\Wide310x150Logo.png" />
</uap:VisualElements>
</Application>
</Applications>
</Package>
Manually editing and changing line:
Publisher='CN=Level 7 Systems Ltd.,O=Level 7 Systems Ltd.,POSTALCODE=N12 0DR,STREET=2 Woodberry Grove+STREET=1st Floor,L=London,ST=Greater London,C=GB'
to:
Publisher='CN=Level 7 Systems Ltd.'
and running:
C:\Users\level7\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.4.0\windows-10\ia32\makeappx.exe pack /o /f C:\Users\level7\Desktop\electron-softphone\electron\dist\__appx-ia32\mapping.txt /p cae0a702dee6d01422d41f5cc1a2734c26bf688087aaf5479190f7bb2aed5f60
fixes the issue, but not sure how to make this work withing electron-builder packaging flow.
Any suggestions greatly appreciated.
Regards, Chris
About this issue
- Original URL
- State: open
- Created 6 years ago
- Reactions: 4
- Comments: 21 (2 by maintainers)
Commits related to this issue
- fix:(appx): invalid CA publisher syntax from app-builder (#3501, #4931) honor publisher in `package.json`, for example: ```JSON "build": { "appx": { "publisher": "CN=\"Bob Doe\", O=\"Bob ... — committed to rainbean/electron-builder by rainbean 4 years ago
- fix:(appx): invalid CA publisher syntax from app-builder (#3501, #4931) (#5356) honor publisher in `package.json`, for example: ```JSON "build": { "appx": { "publisher": "CN=\"Bob Doe... — committed to electron-userland/electron-builder by rainbean 4 years ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please Re-open this issue, Apparently the Regex for electron-builder doesn’t recognize ST value that some certificates provide. Can we update the Regex to allow for ST? I am having the same issue as this person is and it seems to be connected to the “ST” value that is being used for State in the USA.
I’m also experiencing this issue when trying to sign an appX for self distribution.
When signing an appX using the certificate environment variables it seems like electron-builder is setting the publisher to the certificate publisher which then fails the regular expression check in Microsoft’s MakeAppx tool. This also happens when specifying the certificate outside of the environment variables and in the JSON configuration file.
So when the certificate is set the AppxManifest shows the following and the build fails due to the MakeAppx regular expression not passing.
When no certificate is set it shows the following which builds fine, however the appX is unsigned.
It looks like it is pulling the publisher name from the code signing certificate incorrectly and this is causing issues.
I faced this problem and was able to sign my appx by setting appx.publisher in my electron-builder config to the certificate subject (which has S= instead of ST=). Not sure if it can help anyone in this thread.
I don’t understand why people here are describing the issue as specific to Sectigo. My certificate is also from Sectigo, but I don’t think that’s my issue. electron-builder sets the
Publisherin myAppxManifest.xmlto my personal name, rather than the CN of my certificate authority (Sectigo). The real issue for me is that electron-builder/app-builder mangles my CN, such that makeappx rejects it.That is not parsing correctly as you can see the first item parses, it has blue highlighting on CN= but the ST is not highlighted, showing it does not correctly identify that as a valid option. I have been in contact with Ksoftware and they say they run into this problem commonly for the windows store and there is a way they can remove the fields and reissue the cert to get around this issue. But the Regex still needs to be updated to fix this issue, this additional data is unfortunately irrelevant.
And if you go here https://regex101.com/ And you put the REGEXP and the String to test, it parses correctly.
I don’t know if might be related or not, but if you try to navigate directly to http://schemas.microsoft.com/appx/manifest/foundation/windows10
you get a 404 Error Response.
Here is a way that you could verify the failing test… in test\src\windows\winCodeSignTest.ts alter the first test to the following.
test(“parseDn”, () => { expect(parseDn(“CN=7digital Limited, O=7digital Limited, L=London, ST= Greater London, C=GB”)).toMatchSnapshot()
expect(safeLoad(“publisherName:\n - 7digital Limited”)).toMatchObject({publisherName: [“7digital Limited”]}) })
this should cause that test to fail and should help you trace where to fix it.
I truly wish i could but i cant seem to find where the Regex is that is listed below. I would just be adding the ST option to the list. I have contacted my Code signing cert issuer to see if i could get State listed as a different field in the meantime, but fixing it this way would be better. I have listed my error and stacktrace below, hopefully it will help in finding the regex pattern and being able to change it. I searched for about 2 hours through the package and couldn’t seem to find where the pattern is stored.
Using “D:\Projects\trueadherenceapp\release__appx-x64\AppxManifest.xml” as the manifest for the package. MakeAppx : error: Error info: /[local-name()=“Package” and namespace-uri()=“http://schemas.microsoft.com/appx/manifest/foundation/windows10"]/*[local-name()="Identity” and namespace-uri()=“http://schemas.microsoft.com/appx/manifest/foundation/windows10”][1]/@Publisher ‘CN=True Adherence Inc,O=True Adherence Inc,L=Salt Lake City,ST=Utah,C=US’ violates pattern constraint of '(CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|Description|PostalCode|POBox|Phone|X21Address|dnQualifier|(OID.(0|[1-9][0-9])(.(0|[1-9][0-9]))+))=(([^,+=“<>#;])+|”.“)(, ((CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|Description|PostalCode|POBox|Phone|X21Address|dnQualifier|(OID.(0|[1-9][0-9])(.(0|[1-9][0-9]))+))=(([^,+=”<>#;])+|".")))'. The attribute ‘Publisher’ with value ‘CN=True Adherence Inc,O=True Adherence Inc,L=Salt Lake City,ST=Utah,C=US’ failed to parse. MakeAppx : error: Package creation failed. MakeAppx : error: 0x80080204 - The specified package format is not valid: The package manifest is not valid. stackTrace= Error: Exit code: 1. Command failed: C:\Users\chris\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0\windows-10\x64\makeappx.exe pack /o /f D:\Projects\trueadherenceapp\release__appx-x64\mapping.txt /p b142b6716aa7f7dca75af001c90acf438281f8369b20a86292621350b47fa118 (sha256 hash) 0.4.0.appx
MakeAppx : error: Package creation failed. MakeAppx : error: 0x80080204 - The specified package format is not valid: The package manifest is not valid.
at D:\Projects\trueadherenceapp\node_modules\builder-util\src\util.ts:125:16 at ChildProcess.exithandler (child_process.js:302:5) at ChildProcess.emit (events.js:210:5) at maybeClose (internal/child_process.js:1021:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)