desktop: "GitHub Desktop failed to launch" after latest update

Description

“GitHub Desktop failed to launch” after latest update

Version

GitHub Desktop version: 1.0.7 OS version: Windows 10.0.14393

Steps to Reproduce

Restart GitHub Desktop app to install latest update (1.0.7)

Expected behavior: N/A

Actual behavior: App crashes right after opening

Reproduces how often: Always

Logs

Error: Mode github-diff-syntax failed to advance stream.
    at at (app\node_modules\codemirror\lib\codemirror.js:1639:1)
    at dt (app\node_modules\codemirror\lib\codemirror.js:1693:1)
    at tt (app\node_modules\codemirror\lib\codemirror.js:1539:1)
    at C:\Users\<USERNAME>\AppData\Local\GitHubDesktop\app-1.0.7\webpack:\app\node_modules\codemirror\lib\codemirror.js:4063:24
    at Jr.iterN (app\node_modules\codemirror\lib\codemirror.js:5539:8)
    at Bs.iterN (app\node_modules\codemirror\lib\codemirror.js:5651:41)
    at Bs.iter (app\node_modules\codemirror\lib\codemirror.js:6047:14)
    at Do (app\node_modules\codemirror\lib\codemirror.js:4058:1)
    at C:\Users\<USERNAME>\AppData\Local\GitHubDesktop\app-1.0.7\webpack:\app\node_modules\codemirror\lib\codemirror.js:148:21

Version: 1.0.7
OS: Windows 10.0.14393

About this issue

Original URL
State: closed
Created 7 years ago
Reactions: 3
Comments: 19 (7 by maintainers)

Most upvoted comments

We just released 1.0.8 with the fix. Thank you all for reporting it and your patience as we fixed it 💖

joshaber on Nov 7, 2017

Experiencing the same issue.

It only happens when {$ is part of a string enclosed in double quotes, like @filipsobol already mentioned.

It doesn’t seem to cause a crash when {$ is used in other ways like 'Welcome {$name}s!' and $foo->{$bar}.

chunfeilung on Nov 7, 2017

I found the cause of this - “{$” (opening curly brace followed by dollar sign). In PHP it’s possible to concatenate string and variable like this:

echo "Welcome {$name}s!"

filipsobol on Nov 7, 2017

Private BitBucket repo… unfortunately I can’t check with other repos, because app crashes immediately 😢

filipsobol on Nov 7, 2017

#3258 which contains a fix for this has been merged and we’re going to try to get a new release out as quickly as possible. Thanks for bearing with us while we work to resolve this issue.

niik on Nov 7, 2017

Thank you all for your help with this! I’ve been able to reproduce the problem. I’ll update as soon as I have a fix or workaround for this.

niik on Nov 7, 2017