darkreader: [Bug] Keyboard shortcut to toggle DR v4.9.37.1 not working

Bug Report

Bug Description

Keyboard shortcut to toggle DR v4.9.37.1 not working.

Website Address

All

Steps To Reproduce

Upgraded DR to v4.9.37.1
Restarted Firefox
Pressed keyboard shortcut to toggle DR - it toggled correctly
Pressed keyboard shortcut to toggle DR again - nothing happened
Repeated step 4 - still nothing
Restarted Firefox
Repeated step 4 - still nothing

Expected Behavior

Keyboard shortcut to toggle DR to, um, toggle DR

Actual Behavior

See above

System Information

OS: Windows
Browser: Firefox 92.0.1
Dark Reader Version: 4.9.37.1

Additional Context

I do have a custom keyboard shortcut defined for this behaviour in about:addons.

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 1
Comments: 18 (15 by maintainers)

Most upvoted comments

I did a little testing of different versions on new profile and here are the results:

Version 4.9.34 and before: everything works as intended
Version 4.9.35: all toggle shortcuts don’t work ,toggling DR on/off via popup works only once, toggling via popup for current site works as many times as you want, but only until you toggle DR off once. As a result you get a totally unresponsive DR.
Version 4.9.36: all toggle shortcuts do work at first, though site settings aren’t preserved after page refresh or toggling DR on/off. !!! BUT after toggling DR on/off via popup once all toggle shortcuts stop working again, just like in version 4.9.35 !!! I also get same broken behavior as I mentioned above after trying to toggle DR for specific site via shortcut when DR is turned off…
Version 4.9.37.1: same as 4.9.36

My point is: This is not a issue in just 4.9.37.1, but also 4.9.36 or even before that, since the last working as intended version is 4.9.34. Hope it helps you a little…

System information

* OS: xubuntu 18.04.05 LTS

* Browser: Firefox 90.0

* Dark Reader Version: 4.9.37.1

Altgear on Oct 22, 2021