darkreader: [BUG] Error in event handler: TypeError: Cannot read property 'l' of null

Describe the bug

No dark theme on some websites

Steps to reproduce

visit a website

Expected behavior

Dark theme

Actual behavior

There is no dark theme, Dark Reader generates an error when trying to make a dark theme.

Error in event handler: TypeError: Cannot read property 'l' of null
    at modifyBgHSL (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:1309:60)
    at modifyColorWithCache (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:1244:26)
    at modifyBackgroundColor (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:1332:16)
    at getModifiedFallbackStyle (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:1939:38)
    at createStaticStyleOverrides (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:3569:37)
    at createThemeAndWatchForUpdates (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:3794:9)
    at createOrUpdateDynamicTheme (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:3902:13)
    at onMessage (chrome-extension://eimadpbcbfnmbkopoojfekhnkhdbieeh/inject/index.js:3981:17)

The error is here:

So far it’s occurred on YouTube (old theme) and GitHub (this page)

Screenshots

System Information:

OS: macOS Mojave 10.14.6
Browser: Chrome 83.0.4103.97 (Official Build) (64-bit)
Dark Reader version: 4.9.11

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 23 (11 by maintainers)

Commits related to this issue

Migrate customTheme's theme object - Resolves #2966 — committed to darkreader/darkreader by Gusted 4 years ago
Migrate customTheme's theme object (#2968) - Resolves #2966 - Migrate new theme's options into site specific theme's object. — committed to darkreader/darkreader by Gusted 4 years ago

Most upvoted comments

alexanderbyToday at 15:30
Great, thanks!

I will push another update.

Their you go! Now you should wait on google to review it and push the update to users. Thank you for reporting this quite criticial issue!

Gusted on Jun 28, 2020