darkreader: [BUG] Clearing all data does not quite clear all data (revealed during export)
Describe the bug
In v4.9.26 with the v5 preview enabled, there is an option to clear all data. It almost works, but when I then performed an export, there was 1 site still listed in the siteList section of the export.
Steps to reproduce
- Enable the v5 preview mode in v4.9.26
- Use DR regularly. including enabling and disabling sites for it
- Click on the option to clear all settings
- Perform a settings export
- Open the export file
Expected behavior
All data will be cleared, thus generating an export file with only default values.
Actual behavior
The export file included 1 site that was previously excluded from being processed by DR.
System Information:
- OS: Windows
- Browser: Firefox 84
- Dark Reader version: 4.9.26, with v5 preview enabled
About this issue
- Original URL
- State: open
- Created 3 years ago
- Comments: 25 (25 by maintainers)
Don’t attempt viewing the log on your smartwatch! 😃 😃 😃
https://github.com/darkreader/darkreader/issues/4722#issuecomment-757570348
Interesting… hmmm… can you edit the second sentence you wrote… I’m having difficulty understanding what you meant.
I’ll perform the other steps you requested right now.
Yes, specifically I used this hack that I provided: https://github.com/darkreader/darkreader/issues/3927#issuecomment-716642446
Before continuing because I’m reproducing the issue as well, you imported the settings trough the hack mentioned over at #3927 so it will actually import the settings.
Well yeah, I don’t always have my phone/laptop/desktop on me, but with my Smartwatch it’s a different story 😛
@Gusted Sounds good. Give me a few minutes to write something cohesive. I just finished creating STR that, on my end, reproduces the issue 100%. I’ll post the STR before testing on a browser with default settings so I can get your feedback before I do that.