darkreader: [BUG] Changes to Dynamic Theme get reverted/deleted
Describe the bug
When I use DR’s dev tools to modify the default Dynamic Theme, the changes get reverted.
Steps to reproduce
- Set Firefox to delete all items (cache, etc.) on close
- Disable syncing DR dynamic theme updates
- Using DR dev tools (v5 preview), add CSS rulesets to the
*section of the dynamic theme - Close Firefox
- Reopen Firefox
- Inspect the DR dynamic theme
Expected behavior
Changes to dynamic theme not lost
Actual behavior
All changes to dynamic theme get reverted
System Information:
- OS: Windows
- Browser: Firefox 83
- Dark Reader version: Version 5 Preview (4.9.26)
Additional context
Although this looks like a bug, it could possibly be an unintended consequence of not conveying when (and why) the dynamic theme would get reverted.
The bottom line is that I would like to be able to make changes to the dynamic theme and not lose those changes. I have not submitted these changes to be applied to all Dark Reader users because they may only be applicable to specific OS themes, and possibly only specific browsers. The changes involve modifying the CSS for all input, select, and textarea HTML elements. For example:
input, select, textarea { color: var(--darkreader-selection-text) !important; }
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 31 (21 by maintainers)
See #7359
As I jokingly say to a good friend of mine, “Your issues have issues.” 😃
Yes
When will the new version be released?
That was another issue, it’s fixed in the next release.
the editor does remember the css but i still have to open it and click on apply everytime i restart the browser for the changes to take place. was this intended or some issue with my browser?
Okay, thanks a lot, hope to see it fixed soon.
I see that the PR’s are merged, when can we expect a release for the same?
I thought the issue was resolved, but I may not be remembering correctly because, for the most part, I stopped using Dark Reader’s editor. I found it much faster to add style filters to uBO to fix dynamic dark mode issues instead of using Dark Reader’s dynamic theme editor.
For changes to the default dynamic mode that I thought would benefit others, I started creating pull requests in this repo so everyone can benefit. I’m still doing that once in a while, but I’ve slowed down because those pull requests must support dark and light dynamic modes, and I only use Dark Reader for dark modes. I have hundreds of dynamic dark mode overrides, and it was taking too much time to support dynamic light mode too (do more than 2 people use that?).
#4472