danger: Inline comments are always stuck out

Report

What did you do?

I am running Danger on Bitrise (using the built-in step).

The command that is ran is:

bundle "exec" "danger" "--fail-on-errors=true"

I configured the Dangerfile to have inline comments. It looks like the inline comments are always struck out. If I disable inline comments, the main comment sent to the PR has regular formatting.

At first, I thought that this was a bug in the android_lint plugin, but then I configured our iOS project with swiftlint and the behavior is the same.

What did you expect to happen?

The inline comments show without a strike.

Here is an example without inline comments. The text is normal.

Screenshot 2020-02-19 at 07 39 32

What happened instead?

Screenshot 2020-02-19 at 07 37 13

As you can see, the text is struck out, which is not expected. It looks like the error was corrected, which is not the case.

Your Environment

  • Which CI are you running on?
    • Bitrise
  • Are you running the latest version of Danger?
    • Yes, 6.2.2
  • What is your Dangerfile?

On iOS:

swiftlint.config_file = 'app/.swiftlint.yml'
swiftlint.verbose = true
swiftlint.max_num_violations = 20
swiftlint.lint_files inline_mode: true

On Android:

checkstyle_dir = "**/build/reports/detekt/detekt.xml"
Dir[checkstyle_dir].each do |file_name|
  checkstyle_format.base_path = Dir.pwd
  checkstyle_format.report file_name
end

lint_dir = "**/build/reports/lint-**.xml"
Dir[lint_dir].each do |file_name|
  android_lint.skip_gradle_task = true
  android_lint.filtering = true
  android_lint.report_file = file_name
  android_lint.lint(inline_mode: true)
end

junit_tests_dir = "**/test-results/**/*.xml"
Dir[junit_tests_dir].each do |file_name|
  junit.parse file_name
  junit.report
end

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 1
  • Comments: 18 (5 by maintainers)

Most upvoted comments

I can confirm that this is fixed. Thanks!