danger: Incorrect MR ID for GitLab with Drone

Report

What did you do?

I ran Danger on Drone using a private GitLab instance.

What did you expect to happen?

I expected Danger to run correctly.

What happened instead?

Danger ran, but failed because the ID used to fetched the merge request details was the iid(the project specific merge request id) not the global merge request id that the API expects.

Your Environment

  • Which CI are you running on? Drone
  • Are you running the latest version of Danger? Yes

About this issue

  • Original URL
  • State: open
  • Created 8 years ago
  • Comments: 44 (36 by maintainers)

Most upvoted comments

I’ve updated danger-gitlab to 4.3.1 ( to coincide with when we introduced these changes ) which relies on gitlab 4.0.0. - thanks @asedge

+4
orta on Apr 10, 2017

Guys this is awesome . I’m dropping the workaround and coming back to the official version. Many thanks

+1
thebugcode on Apr 11, 2017
Read more comments on GitHub
← danger: Git Fatal on Danger Branches
danger: Inline comments are always stuck out →