cypress: Cypress v13: Can't resolve '@cypress/code-coverage/support' using Yarn PnP
Current behavior
When importing @cypress/code-coverage/support in the support file like this:
cypress/support/e2e.ts:
import '@cypress/code-coverage/support';
import './commands';
...
...
cypress is throwing an error:
Oops...we found an error preparing this test file:
> tests/cypress/support/e2e.ts
The error was:
Error: Webpack Compilation Error
Module not found: Error: Can't resolve '@cypress/code-coverage/support' in '/Users/wataruian/projects/monorepo/packages/frontend/tests/cypress/support'
at handle (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/@cypress/webpack-preprocessor/dist/index.js:212:23)
at finalCallback (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:441:32)
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:505:17
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/HookWebpackError.js:68:3
at Hook.eval [as callAsync] (eval at create (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/tapable/lib/Hook.js:18:14)
at Cache.storeBuildDependencies (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Cache.js:122:37)
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:501:19
at Hook.eval [as callAsync] (eval at create (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/tapable/lib/Hook.js:18:14)
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:498:23
at Compiler.emitRecords (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:919:5)
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:490:11
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:885:14
at Hook.eval [as callAsync] (eval at create (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/tapable/lib/Hook.js:18:14)
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:882:27
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/neo-async/async.js:2818:7
at done (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/neo-async/async.js:3522:9)
at alreadyWritten (/Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:714:8)
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/webpack/lib/Compiler.js:802:19
at /Users/wataruian/Library/Caches/Cypress/13.3.0/Cypress.app/Contents/Resources/app/node_modules/graceful-fs/graceful-fs.js:123:16
This occurred while Cypress was compiling and bundling your test code. This is usually caused by:
- A missing file or dependency
- A syntax error in the file or one of its dependencies
Fix the error in your code and re-run your tests.
But when the import is removed, cypress is working fine but is not desired since code coverage functionality will also be removed.
The error occurred after updating to ^13.3.0, everything is working fine on ^12.17.1 with Yarn PnP (3.5.0).
Desired behavior
Code coverage should work regardless of the cypress version using Yarn PnP.
Test code to reproduce
- Install Yarn PnP version 3.5.0
- Install cypress version ^13.3.0
- Import
@cypress/code-coverage/supportin the support file - Run cypress
Cypress Version
^13.3.0
Node version
v18.15.0
Operating System
Apple M2 Pro: macOS 13.5.2 (22G91)
Debug Logs
No response
Other
No response
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 4
- Comments: 22 (8 by maintainers)
Installed and it looks like it works! Tests run fine, nothing in the logs. Really excited for this development!
Since this issue doesn’t provide one, and I put in the effort, I’m going to put my minimum reproducible example on here: https://github.com/dclowd9901/cypress-13-yarn-pnp-workspace-bug-minimum-reproducible-example/blob/main/README.md
@wataruian
This issue is also reproducible with:
cypress@13.3.0cypress.config.js@cypress/code-coverage@3.12.120.8.022.04.3 LTS3.6.3pnpCypress has multiple unresolved compatibility issues with Yarn Modern Plug’n’Play at this time, especially for Component Testing. If you need to migrate to Cypress
13.x, then you could usenode-modules(orpnpm) instead ofpnp, for instance through the workaround:then
should work.
I think that is the wrong binary. can you try npm install https://cdn.cypress.io/beta/npm/13.13.2/darwin-arm64/fix/webpack-batteries-included-for-yarn-pnp-5345c1b2bfad7f1b0b6949c569d63e3507a0873f/cypress.tgz?
Awesome. For our part, I’ll pull down the commit and check it on our stuff.
Good news @dclowd9901 . I actually messed up the original attempt at fixing this and updated
enhanced-resolvein the wrong hoisted dependency directory. It looks to be working correctly with the reproduction, plus a few other fixes… Are you or anyone else able to try out the binaries on this commit?This looks like it might be an issue with webpack 5. Before in webpack 4, we were able to discover
pnpApiwith thepnp-webpack-plugin. Webpack now is supposed to discover this by default, but because the cypress process hosting webpack does not install dependencies viapnp, webpack is trying to look in thenode_modulesfolder of the project/test directory, which is not correct. I have created a reproduction outside of cypress to showcase the issue an opened an issue with webpack https://github.com/webpack/webpack/issues/18586.its a bit complicated since cypress installs as an npm package, but ultimately executes a binary that lives in the cache directory, which ships with the
webpack-preprocessors that we need to debug, so it unlikely won’t be as simple as unzipping the installed dep. Going to start back up on this in a few and see what I come up with.Darn, was really hoping for it to be an easy fix there.
Unplugging that dependency might be a cheap and quick way to “unzip” the packages you’re wanting to debug? Anyway, happy to bounce ideas – I’m on Discord at
ddrew6012. So grateful y’all are looking into this.I had a little bit of time to take a look at the issue this morning. Going to jot down some of my notes…
With the reproduction provided:
Cypress
12.12.0doesn’t work.The patch to
enhanced-resolvein12.13.0works12.14.0introduces webpack 5, which breaks pnp here since we are unable to discover pnp. The plugin code should have been gated which looks like a miss on our end. Either way, not usingwebpack-pnp-plugindoes not seem to fix the problem.Updating
enhanced-resolveto5.17.0does not fix the problem.Likely this has to do with the webpack 5 update to the preprocessor since webpack 5 is supposed to handle pnp resolutions OOTB. But when the webpack compiler attempts to compile the file, the dependencies can’t be found.
This might be an issue with my local setup since I am running yarn 1.22.1 on the cypress project against a project with yarn 4 / pnp. Maybe since webpack believes it can auto resolve pnp, and sees yarn 1.22.1, it figures pnp may not be enabled.
It might be worth it to edit the web pack-preprocessor / webpack-batteries-included-preprocessor from the actual installed binary and debug the code that way since we know we are running on the correct yarn. However the cache directories are all zip files which might make debugging challenging.
Hoping to look at this more later this week.
I can confirm that with yarn4 and NX17 I’m getting an error
(none of the cypress@12 and cypress@13 seem to be working) right now for me so upgrade to yarn4 is broken
Careful with unspecific v12, since 12.17.4 has another pnp-bug 😃