crc: CodeReady Studio 'crc setup detection' algorithm broken with CRC 1.24.0

General information

OS: Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)?No
Running CRC on: Laptop

CRC version

CodeReady Containers version: 1.24.0+5f06e84b
OpenShift version: 4.7.2 (embedded in executable)

CRC status

# Put `crc status --log-level debug` output here

CRC config

Machine does not exist. Use 'crc start' to create it

Host Operating System


Nom de l’hôte:                              DESKTOP-U2EVGBM
Nom du système d’exploitation:              Microsoft Windows 10 Professionnel
Version du système:                         10.0.19042 N/A build 19042
Fabricant du système d’exploitation:        Microsoft Corporation
Configuration du système d’exploitation:    Station de travail autonome
Type de build du système d’exploitation:    Multiprocessor Free
Propriétaire enregistré:                    Jeff MAURY
Organisation enregistrée:                   
Identificateur de produit:                  00330-80819-37372-AA911
Date d’installation originale:              29/06/2020, 14:54:33
Heure de démarrage du système:              29/03/2021, 15:14:51
Fabricant du système:                       LENOVO
Modèle du système:                          20LAS3NJ0H
Type du système:                            x64-based PC
Processeur(s):                              1 processeur(s) installé(s).
                                            [01] : Intel64 Family 6 Model 142 Stepping 10 GenuineIntel ~1910 MHz
Version du BIOS:                            LENOVO N27ET36W (1.22 ), 04/07/2019
Répertoire Windows:                         C:\WINDOWS
Répertoire système:                         C:\WINDOWS\system32
Périphérique d’amorçage:                    \Device\HarddiskVolume1
Option régionale du système:                fr;Français (France)
Paramètres régionaux d’entrée:              fr;Français (France)
Fuseau horaire:                             (UTC+01:00) Bruxelles, Copenhague, Madrid, Paris
Mémoire physique totale:                    32 379 Mo
Mémoire physique disponible:                12 884 Mo
Mémoire virtuelle : taille maximale:        57 979 Mo
Mémoire virtuelle : disponible:             30 613 Mo
Mémoire virtuelle : en cours d’utilisation: 27 366 Mo
Emplacements des fichiers d’échange:        C:\pagefile.sys
Domaine:                                    WORKGROUP
Serveur d’ouverture de session:             \\DESKTOP-U2EVGBM
Correctif(s):                               15 Corrections installées.
                                            [01]: KB4601554
                                            [02]: KB4560366
                                            [03]: KB4561600
                                            [04]: KB4562830
                                            [05]: KB4566785
                                            [06]: KB4570334
                                            [07]: KB4577266
                                            [08]: KB4577586
                                            [09]: KB4580325
                                            [10]: KB4586864
                                            [11]: KB4589212
                                            [12]: KB4593175
                                            [13]: KB4598481
                                            [14]: KB5000802
                                            [15]: KB5000858
Carte(s) réseau:                            6 carte(s) réseau installée(s).
                                            [01]: TAP-Windows Adapter V9
                                                  Nom de la connexion : Ethernet 2
                                                  DHCP activé :         Oui
                                                  Serveur DHCP :        10.36.127.254
                                                  Adresse(s) IP
                                                  [01]: 10.36.115.194
                                                  [02]: fe80::d527:58a7:4965:c2ad
                                            [02]: Bluetooth Device (Personal Area Network)
                                                  Nom de la connexion : Connexion réseau Bluetooth
                                                  État :                Support déconnecté
                                            [03]: Intel(R) Dual Band Wireless-AC 8265
                                                  Nom de la connexion : Wi-Fi
                                                  DHCP activé :         Oui
                                                  Serveur DHCP :        192.168.0.254
                                                  Adresse(s) IP
                                                  [01]: 192.168.0.41
                                            [04]: Intel(R) Ethernet Connection (4) I219-LM
                                                  Nom de la connexion : Ethernet
                                                  État :                Support déconnecté
                                            [05]: Hyper-V Virtual Ethernet Adapter
                                                  Nom de la connexion : vEthernet (Default Switch)
                                                  DHCP activé :         Non
                                                  Adresse(s) IP
                                                  [01]: 172.23.192.1
                                                  [02]: fe80::1186:c938:a49b:4bda
                                            [06]: Hyper-V Virtual Ethernet Adapter
                                                  Nom de la connexion : vEthernet (minishift)
                                                  DHCP activé :         Non
                                                  Adresse(s) IP
                                                  [01]: 172.16.0.1
                                                  [02]: fe80::3881:3360:4d27:e878
Configuration requise pour Hyper-V:         Un hyperviseur a été détecté. Les fonctionnalités nécessaires à Hyper-V ne seront pas affichées.

Steps to reproduce

The CRC integration into CodeReady Studio that detects if CRC setup needs to be executed. It is based on the existence of:

$HOME/.crc folder
$HOME/.crc/crc.json file
$HOME/.crc/crc.log file
$HOME/.crc/bin folder
$HOME/.crc/bin/oc or $HOME/.crc/bin/oc.exe file

if check returns false we run crc setup then recheck before running crc start. As the oc binary is not extracted under $HOME/.crc/bin start integration is failing. @robstryker can comment about Linux use case

Is this change permanent ?

Expected

Actual

Logs

Before gather the logs try following if that fix your issue

$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start --log-level debug

Please consider posting the output of crc start --log-level debug on http://gist.github.com/ and post the link in the issue.

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 29 (19 by maintainers)

Commits related to this issue

Add --checks-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --checks-only INFO Checking if running as non-root INFO Checki... — committed to cfergeau/crc by cfergeau 3 years ago
Add --checks-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --checks-only INFO Checking if running as non-root INFO Checki... — committed to cfergeau/crc by cfergeau 3 years ago
Add --checks-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --checks-only INFO Checking if running as non-root INFO Checki... — committed to cfergeau/crc by cfergeau 3 years ago
Add --check-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --check-only INFO Checking if running as non-root INFO Checking... — committed to cfergeau/crc by cfergeau 3 years ago
Add --check-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --check-only INFO Checking if running as non-root INFO Checking... — committed to cfergeau/crc by cfergeau 3 years ago
Add --check-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --check-only INFO Checking if running as non-root INFO Checking... — committed to cfergeau/crc by cfergeau 3 years ago
Add --check-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --check-only INFO Checking if running as non-root INFO Checking... — committed to cfergeau/crc by cfergeau 3 years ago
Add --check-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --check-only INFO Checking if running as non-root INFO Checking... — committed to cfergeau/crc by cfergeau 3 years ago
Add --check-only to crc setup This adds a way of checking if `crc setup` has to be run before `crc start` can be called: $ ./crc setup --check-only INFO Checking if running as non-root INFO Checking... — committed to crc-org/crc by cfergeau 3 years ago

Most upvoted comments

According to the documentation the steps are:
1. `crc setup`

2. `crc start`

3. and usage
While I agree that this is very much sending people for a runaround. Though, crc start concludes the right thing.

For crc status we need a PTY terminal (to hide typed passwords)

^^^ are you sure? I believe you meant crc setup.

workaround is to launch it through a PTY process launcher

If so, yes… but this will be handled in ‘future’ by the OS on macOS as this will be replaced by the yellow package. but …

we’d be very happy if crc setup was removed, and crc start did it automatically as part of the first startup

You can prevent the popups and requests for the password IF you supply the pull-secret by file via crc config set. This has been implemented IIRC by the VScode adapters. We worked to add configu options which can be provided beforehand to prevent those Are you sure ? We provide pull secret via command line arguments, Rob was referring to sudo like password which I don’t think can be prevented

In other words, a quick conversation in our IRC channel or slack channel would have been able to resolve this.

jeffmaury on Apr 2, 2021