brave-browser: Browser crashes when invalid EIP712 request data is submitted
Description
Steps to Reproduce
- clone https://github.com/coinspect/test-dapp-eip-712 and modify line 133 to be
{ name: 'name', type: 1234 }, - start DApp and connect to wallet
- click
sign
Actual result:
browser crash
Expected result:
Should fail gracefully and not crash the browser process
Reproduces how often:
Easily reproduced
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 17 (15 by maintainers)
closed in favor of https://github.com/brave/brave-browser/issues/30212
That’s correct @kjozwiak it’s not merged yet. I got stuck trying to resolve a CI build issue on https://github.com/brave/brave-core/pull/17292 and haven’t spent the time to try and resolve that yet.
@kdenhartog closed https://github.com/brave/brave-core/pull/17099#pullrequestreview-1302104041 & https://github.com/brave/brave-core/pull/17100#pullrequestreview-1302105403 as it looks like the above is still an issue. Once the issue that @srirambv found has been fixed, lets create new uplifts 👍 If this needs to go out ASAP, the
1.48.xmaintenance release is scheduled onFebruary 22as per https://github.com/brave/brave-core/pull/17100#pullrequestreview-1302105403. If it doesn’t make it, we can just uplift into1.49.xif needed.