brave-browser: Browser crash when attempting to tweet after tipping
After tipping, clicking on Tweet may crash the browser
Steps to Reproduce
- Clean install on staging
- Enable Rewards
- Claim grant or fund wallet another way
- Open publisher page (
https://www.reddit.com/user/jsadler-brave) - Use inline tipping
- Click tip amount
- Quickly click another tip amount (repeat few times)
- Immediately click
SEND MY TIP - Immediately click
Tweet
Note: This is an Intermittent issue, if browser does not crash, start from step 5.
Actual result:
Browser Crash. Needs to run the browser again.
Windows 7 Uploaded Crash Report ID 7c1b0025c7afe8b9 (Local Context: fe8dec3f-846c-494d-8c7f-6305e621f7a0) Ubuntu 18.04 LTS Crash Report ID d165028fa3f61bfa
Expected result:
No crash
Reproduces how often:
Intermittent issue, around 20% repro rate
Brave version (brave://version info)
| Brave | 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit) |
|---|---|
| Revision | 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967} |
| OS | Ubuntu 18.04 LTS |
| Brave | 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit) |
|---|---|
| Revision | 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967} |
| OS | Windows 7 Service Pack 1 (Build 7601.24494) |
Reproduced on staging and production. Also reproduced by tipping youtube publisher.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 34 (10 by maintainers)
I managed to record it.
I used staging env with a grant. I was connected to Belgium through VPN.
I also noticed that if crash does not reproduce, there is no need to start from step 1. It is OK to start from step 5.
Uploaded crash id for this crash: 0e594ec66abf309d
@kjozwiak The crash report was not generated. Probably due to https://github.com/brave/brave-browser/issues/4296.
@btlechowski mind taking a look at this one as you’re the one that could reproduce this pretty consistently. I went through your original STR/Cases via https://github.com/brave/brave-browser/issues/5516#issue-476182283 at least ~40 times and couldn’t reproduce.
I am still able to reproduce the crash. I was testing on staging with grant.
Uploaded Crash Report ID 0e2953da93e8455a (Local Context: Brave)
I will try to get a recording tomorrow. Maybe it will help.
@btlechowski @LaurenWags with the fix from PR 3592 (which resolves #6223) I have been unable to reproduce the crash from this issue. I’ve burned through 60 BAT (and I’m a cheap tipper 😉 )and every time the Tweet page loads as expected. I’d recommend retesting this issue once #6223 is resolved (slated for 0.72 nightly ATM).
@btlechowski thank you, I missed it.
@masparrow re grant, your don’t really need the grant, you just need funds to tip
I reproduced the issue with
Tweetbutton. This is not as it used to be before. Maybe it is related to the crash. You should see something like that:Does not reproduce on Twitter(inline tipping), youtube and regular page.
edit: I logged https://github.com/brave/brave-browser/issues/6223. You are very likely blocked on this issue.