bokeh: gridplot with sizing_mode="stretch_both"/"scale_both" is totally broken since 0.12.11

Charts and toolbar are messed up on the screen.

gridplot(self.panelsGrid,
                        toolbar_location = "right",
                        sizing_mode="stretch_both",
                        toolbar_options=dict(logo=None)
                        )

Tested on Bokeh 0.12.11 and 0.12.13
Running in bokeh serve mode
Server OS: Debian 9
Tornado: 4.5.3
Browser: Chrome, IE 11

I think this MR is breaking it - https://github.com/bokeh/bokeh/pull/7008

Screenshot before browser resizing:

Screenshot after browser resizing

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 6
Comments: 15 (6 by maintainers)

Most upvoted comments

@cloud-rocket there is currently far more work, than there are people to do it. That mean many things, even important things, will often take a long time. I can’t speculate when this will be looked at, the only way to accelerate things is for more people to get involved in contributing.

bryevdv on Jan 29, 2018

OK so as the next best thing I tested the anscombe example with stretch_both:

Also tested with scale_width and with a toolbar present. Definitely seems like it can be closed with #8085

bryevdv on Jan 31, 2019

@bryevdv,

Looks like CSS flex mode you added in MR 7008, was not properly added to all elements - when not updated element is added to dashboard, it breaks everything. Probably this is the root problem of multiple recent bug reports with usage of scale_width/scale_height and scale_both.

I tried manually creating a columns/rows or mixture of them with simple figures - and everything is working fine until I am adding a toolbar. While I am trying to add ToolbarBox with ProxyToolbar (also introduced in 7008), the same way it is done in gridplot - it always breaks the whole dashboard. Even when it is a single column (without additional layouts) with toolbar above several figures.

cloud-rocket on Apr 9, 2018