BentoML: Small breaking change to onnx-mlir PyExecution session requires small tweak to open source code
Describe the bug
A change to the onnx-mlir PyExecutionSession requires BentoML’s onnx-mlir PyExecutionSession to be updated with a fix where run_main_graph no longer needs specified in the PyExecutionSession invocation as shown below:
To Reproduce Any workflow using an old copy of the compiled models will need to refresh their compiled model and repack their serving environment. Any discussions for incompatible changes needed beyond that should be discussed with me immediately.
Expected behavior The model should run as expected and give the expected output.
Screenshots/Logs Sufficient documentation has been provided in the documentation above and I or @andrewsi-z will provide the fix for this since he originally authored this code.
Additional context A fix has been discussed with @andrewsi-z and should be straightforward in implementation. I’ll work with the team moving forward to implement the PR.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 22 (12 by maintainers)
Commits related to this issue
- fix: address #2622 Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> — committed to bentoml/BentoML by aarnphm 2 years ago
- fix: address #2622 chore: updates according to spec Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> — committed to bentoml/BentoML by aarnphm 2 years ago
Definitely. @andrewsi-z and I will be talking about how to handle 1.0 moving forward too since we’re also stewards of the onnx-mlir project.
I’ve had my attention directed elsewhere for the last few months with the ongoing 1.0 support. You are correct about the solution though. It’ll be very straightforward.
I’ll get into the slack channel and start poking around