azure-sdk-for-js: DisableResponseDecompressionPolicy error with electron app using azure sdk from angular renderer

I have a desktop app that uses electron and angular. I am trying to upload the Blob storage using @azure/storage-blob in the angular renderer process. When uploadData method is called library will just crash with following error:

Error: Uncaught (in promise): Error: DisableResponseDecompressionPolicy is not supported in browser environment
Error: DisableResponseDecompressionPolicy is not supported in browser environment

Please note I am using nodeIntegration: true when opening the angular portal like below:

     this.mainWindow = new BrowserWindow({
          webPreferences: {
            nodeIntegration: true
         },
        });

From my understanding is that disableResponseDecompressionPolicy is only available in Node.js but this is a common use case where angular apps running inside an electron shell need to communicate with azure-storage. Can we get more clarity on this issue, whether this is a limit in the SDK and how can angular app inside electron work

old issue: https://github.com/Azure/azure-sdk-for-js/issues/14025

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 1
Comments: 18 (12 by maintainers)

Commits related to this issue

CodeGen from PR 20399 in Azure/azure-rest-api-specs [2022-04-01-preview] Add New Api-version for Microsoft.ApiManagement (#20399) * Adds base for updating Microsoft.ApiManagement from version preview... — committed to azure-sdk/azure-sdk-for-js by deleted user 2 years ago

Most upvoted comments

Hi @jeremymeng ,

Any chance to Iadd a browser version isNode implementation which always returns false, would this cause any potential issues?

Thanks Emma

EmmaZhu on May 6, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Issue Details

Error: Uncaught (in promise): Error: DisableResponseDecompressionPolicy is not supported in browser environment
Error: DisableResponseDecompressionPolicy is not supported in browser environment

Please note I am using nodeIntegration: true when opening the angular portal like below:

     this.mainWindow = new BrowserWindow({
          webPreferences: {
            nodeIntegration: true
         },
        });

old issue: https://github.com/Azure/azure-sdk-for-js/issues/14025

Author:	amrit-moomie
Assignees:	EmmaZhu
Labels:	`bug`, `customer-reported`, `Client`, `Storage`, `Service Attention`
Milestone:	-

ghost on Mar 31, 2023

@gingi :

I think the issue is because: The bundler dectects it’s a browserfy environment and choses the browser version DisableResponseCompressionPolicy definition when isNode() is not invoked yet. While in runtime, isNode() is invoked and returns true due to configure of nodeIntegration: true

EmmaZhu on Nov 4, 2022

Hi @jeremymeng ,

I may understand the issue wrong, please correct me if I’m wrong.

The issue here is: when customer set nodeIntegration: true, isNode which detects the environment in runtime would return true, but the file is picked up in compiling and the compiler thinks it’s a browser.

I see we only support disableResponseDecompressionPolicy in Node.JS, because we have no control on whether to decompress response content in Browser environment.

If customer sets nodeIntegration: true, do we have control on on whether to decompress response content? If anyway, we cannot control it, I think maybe ignoring the disableResponseDecompressionPolicy setting with a warning is a good way to go.

Thanks Emma

EmmaZhu on Apr 26, 2022

Storage only uses disableResponseDecompressionPolicy when determined it’s Node.js environment in runtime, but seems for Electron it still selects the browser path.

  if (isNode) {
    // policies only available in Node.js runtime, not in browsers
    factories.push(proxyPolicy(pipelineOptions.proxyOptions));
    factories.push(disableResponseDecompressionPolicy());
  }

@jeremymeng , any suggestions how we could deal with this situation?

Thanks Emma

EmmaZhu on Apr 3, 2022