node-zwave-js: Create a compat flag to Ring Keypad v1 due to duplicate entry control notification sequences
I’ve never seen this before but my Ring keypad v1 has been seeing duplicate sequences even when connected to mains (before that, it would only happen when on battery): ` [Node 057] Received duplicate Entry Control Notification (sequence number 1),ignoring… [Node 057] Received duplicate Entry Control Notification (sequence number 2),ignoring… [Node 057] Received duplicate Entry Control Notification (sequence number 3),ignoring…
` Would it be doable to do a compat flag (ie: ignoreEntryControlSequenceNumber) for it to ignore the duplicates instead of patching the drivers on every release (like I’m doing it now, thanks @marcus-j-davies for the help)?
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (12 by maintainers)
Yeah, that looks like some kind of reset in the device or something. I’ll disable this check as part of
disableStrictEntryControlDataValidation, as the device is more or less unusable without it.@blhoward2,
I think some context might help here.
Entry Control is relatively new in Z-Wave JS, I know of very few devices, that provide this CC, its the ring Keypad, that first made use of it - as far as I am aware.
Now then, The Entry Control specification states, that the
sequenceNumberpart of notifications must be unique, but between the range of 0-255 🤷.The ring pad keypad, has already shown it is not compliant, as there is compat flag for
disableStrictEntryControlDataValidationalready in the config.It turns out, the device likes to send duplicated
sequenceNumbers also. Z-Wave JS ignores these duplicates (providing they have been used in the last 5 notifications) - and rightfully so.However, it means, the notifications are not being forwarded to the front end
Much like
disableStrictEntryControlDataValidation, it maybe of discussion, to also create aignoreEntryControlSequenceNumberto deal with Entry Control devices that don’t follow the proper spec.As mentioned, the way around it currently, is to comment out the duplication checking altogether (for this CC). which is not the best approach obviously, but if a new compat flag could be added, it can be applied to other device configs that may come out, with the same disregard to spec on this CC.