zulip: stream settings: Clicking outside stream permissions modal doesn't close it.
Edit: the issue below is resolved, but see the messages from me and Yash starting at https://github.com/zulip/zulip/issues/12369#issuecomment-499759044
To reproduce:
- As Iago, go to stream settings, and click on a stream
- Click
[Change]on the line that describes the stream permissions - Click anywhere outside the modal that pops up.
It should close the modal; instead, the click goes through.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 17 (8 by maintainers)
Commits related to this issue
- overlays: Fix stream edit click-through bug. Fixes ##12369. — committed to YashRE42/zulip by YashRE42 5 years ago
- overlays: Fix stream edit click-through bug. Fixes ##12369. — committed to YashRE42/zulip by YashRE42 5 years ago
- overlays: Fix stream edit click-through bug. Fixes #12369. — committed to YashRE42/zulip by YashRE42 5 years ago
- settings_user: Fix event propagation for bot and user edit form modal. When the user clicks a button that opens a modal, and if we don't break off the corresponding click event. This condition in the... — committed to pragatiagrawal31/zulip by pragatiagrawal31 4 years ago
- settings_user: Fix event propagation for bot and user edit form modal. When the user clicks a button that opens a modal, and if we don't break off the corresponding click event. This condition in the... — committed to zulip/zulip by pragatiagrawal31 4 years ago
I cannot reproduce it as well.
Thanks for debugging this @YashRE42! @shubhamdhama @YJDave @pragatiagrawal31 https://github.com/zulip/zulip/pull/12517 is worth a read, because this is a pretty common category of bug to accidentally introduce and then someone else spends a day debugging it a year later.