zulip: Inconsistent search results between reaction emoji picker and completion in messagebox

With a custom :thank_you: emoji set (e.g. on c.z.o), typing :thank in the compose box produces: Screen Shot 2021-04-12 at 4 31 59 PM

That is, it finds the custom emoji, and also the :hash: emoji, which it labels thank you, and which selecting produces :thank_you: which renders as the custom :thank_you:. This is one (or one and a half) bugs:

Why does hash show up in the search for thank ?
Why is it labeled thank you in those results?

The emoji reaction picker has a different result: Screen Shot 2021-04-12 at 4 32 15 PM That is, it shows the default :pray: result first, instead of the local override of :thank_you:. This is a third bug: 3. The search results of the emoji reaction picker should match those of the messagebox.

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 16 (11 by maintainers)

Commits related to this issue

emoji typehahead: Fix render_emoji. If you have two emojis of the same name, we were trying to render the non-realm emoji without an emoji_code, since the condition that I changed here was erroneousl... — committed to showell/zulip by showell 3 years ago
emoji typehahead: Fix render_emoji. If you have two emojis of the same name, we were trying to render the non-realm emoji without an emoji_code, since the condition that I changed here was erroneousl... — committed to showell/zulip by showell 3 years ago
emoji typehahead: Fix render_emoji. If you have two emojis of the same name, we were trying to render the non-realm emoji without an emoji_code, since the condition that I changed here was erroneousl... — committed to zulip/zulip by showell 3 years ago
emoji typehahead: Fix render_emoji. If you have two emojis of the same name, we were trying to render the non-realm emoji without an emoji_code, since the condition that I changed here was erroneousl... — committed to Riken-Shah/zulip by showell 3 years ago
emojis: Prioritise custom / realm emojis when sorting. Fixes: #18135. — committed to N-Shar-ma/zulip by N-Shar-ma a year ago
emojis: Prioritise custom / realm emojis when sorting. Fixes: #18135. — committed to N-Shar-ma/zulip by N-Shar-ma a year ago
emojis: Prioritise custom / realm emojis when sorting. Fixes: #18135. — committed to zulip/zulip by N-Shar-ma a year ago

Most upvoted comments

I think there are multiple loosely connected issues at play here:

An emoji can have multiple names associated with it; for example, I checked 🙏 has 4 names - pray, namaste, thank you and welcome. This is great for flexibility while searching for apt emojis but has problems like:
- Collisions where it seems custom emojis take precedence in rendering. A solution for the name collisions maybe to insert the selected emoji directly instead of it’s text representation; which is how GitHub handles emojis.
- Same emojis crowding suggestions under different names (CZO discussion with potential solution).
We currently don’t favour custom emojis when suggesting autocompletions (the original issue), but the code for sorting can be easily changed to, say, show custom emojis after the popular ones.

FYI @alexmv , @alya , @timabbott

N-Shar-ma on Jan 12, 2023

I see consistent ordering.

This doesn’t seem to have made it into my original bug description, but I also consider it a bug that the custom emoji doesn’t sort to the top of the matches.

alexmv on Jan 11, 2023