zulip-desktop: Error: Invalid URI "../renderer/img/icon.png"

This error occurs when we try to saveServerIcon with ../renderer/img/icon.png (which is a fallback icon in case we are unable to get the icon while adding the server) as url parameter, since we then do request to this file which leads to this error obviously. I think we can have a check not to do a request to the request if the url is this file. This will reduce this error.

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 42 (15 by maintainers)

Commits related to this issue

Fix #533 — committed to kanishk98/zulip-desktop by kanishk98 6 years ago

Most upvoted comments

@abhigyank looks like @zulipbot is flaring up. I’ll submit a PR asap regardless; we can fix other things from there.

kanishk98 on Nov 13, 2018

Okay, on the surface, this just seems to be a wrong file path issue. @abhigyank this can be solved simply by replacing ../renderer/img/icon.png with ../../img/icon.png for the saveServerIcon() method to find the appropriate image. I’m unsure of whether this is the best way to solve the issue though.

kanishk98 on Nov 3, 2018

Hello @kanishk98 , you’d be able to reproduce the error if you add a server like “abhigyank.zulipdev.org”. The error occurs due to an invalid image path in of defaultIcon in domain-util.js .

abhigyank on Oct 27, 2018