zlib-ng: Incompatibility with Minecraft Forge
I don’t know which stack the problem existed on. Using this project with ZLIB_COMPAT flags to run Minecraft with Forge would break checks during launch that would otherwise succeed on regular zlib. Just a backlog for the developers.
Original issue: https://github.com/MinecraftForge/MinecraftForge/issues/10173
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 24 (17 by maintainers)
As this is not a bug on our end, I am closing this. I did post a better explanation of the situation related to this anti-pattern on the MinecraftForge issue.
Well, the goal of this project is to be a compatible implementation of zlib, but not a bit perfect one. If we’re sure that’s what’s going on we could probably close this issue but a stronger confirmation of that would be nice. Is it doing a sha1 sum of the output JAR’s bytes? These are effectively zip archives and that would make sense if the originally computed checksum was with a vanilla zlib compressed JAR. Unfortunately with the JAR being both the container and the compression format, there’s no simple computation for the final product that represents the pre-compressed output, which should match identically (I mean, you could write something custom that summed the bytes of every file in the archive but that is quite a bit of work).