desktop: Enable Restore pinned tabs to their originally pinned URL on startup setting does not work
Captchas
- I have read the instructions.
- I have searched existing issues and avoided creating duplicates.
- I am not filing an enhancement request.
- I have checked that this issue cannot be reproduced on Mozilla Firefox.
- I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.
What happened?
Steps:
- Enable Open previous windows and tabs setting
- Enable Restore pinned tabs to their originally pinned URL on startup setting
- Add youtube.com (or other e.g. x.com) to essentials
- Go to a video (or x profile)
- Close browser
- Open browser
Expected behavior: Clicking on essential tab loads youtube.com
Actual behavior: Clicking on essential tab shows youtube.com/video (or x.com/profile) in address bar and endlessly loads, leaving page blank unless refreshed manually.
It has been like this for a couple of versions now, despite working in the past. I have tried clearing cookies/cache, disabling zen mods, disabling extensions, making a new profile. Only disabling “Enable Open previous windows and tabs setting” seems to correctly reset essentials but then your opened tabs are lost.
Version
1.11.1b
What platform are you seeing the problem on?
Windows - x64
What component is this issue related to?
Tabs
Relevant log output if applicable
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 3
- Comments: 53 (34 by maintainers)
Commits related to this issue
- Refactor compact mode logic and enhance pinned tab URL handling (closes https://github.com/zen-browser/desktop/issues/7453#issuecomment-2794479221) — committed to A-SunsetMkt-Forks/desktop-- by mr-cheffy 2 years ago
- fix: bug #7453 - Pinned tabs failing to restore if they got selected before closing, r=split-view, tabs, workspaces — committed to zen-browser/desktop by mr-cheffy 2 years ago
- fix: closes #7453 - Fixed pinning a tab with invalid HOST or about:blank creating an infinite loop of reseting its state, r=tabs — committed to erickirt/desktop by mr-cheffy 2 years ago
- fix: Enable Restore pinned tabs to their originally pinned URL on startup setting does not work, b=(bug #7453), c=tabs — committed to zen-browser/desktop by mr-cheffy 2 years ago
@0Ky Hmmz, cán recreate in a new profile. Bonus: other essentials (those there as demo) got really broken:
@mauro-balades This b0e4681 commit doesn’t fix this issue when testing with an invalid host, even though the commit message claims it does. Why aren’t these changes being tested before merging and closing the issue?
@0Ky You’re right. Saying at least a big part is solved now. Most cases restore, this case does not restore but at least does not crash/corrupt the tab. Still interesting to find (and fix) why this specific case still exists.
@mauro-balades:
Yes, but there’s an issue where the essential tab loads a blank page on startup, which only happens when the essential tab is active right before exiting the browser, as mentioned in my previous comment.
Also, I’m not sure if this is relevant, but the browser console shows the following error when you reproduce the mentioned issue:
When I set
Yes.
I was pointing this out because
@Propheticus Very strange, it should be initialized when you do pin it, but not when you re-open the browser and visit the essential tab. I’ve provided a video demonstration below, I’ll also test it with Windows OS… Have you tested in a fresh profile/installation? Maybe a setting is interfering with the behavior?
@mauro-balades Here’s a video demonstration on a fresh installation, where the cache directory (
~/.cache/zen) and the configuration directory (~/.zen) were also deleted. This demonstration is straight out-of-the-box, with no modifications except for enablingzen.pinned-tab-manager.restore-pinned-tabs-to-pinned-urland installing it usingyay -S zen-browser-binas instructed in the README.Edit: After completing Step 10.,
document.URLdisplaysabout:blankanddocument.readyStateshowsuninitialized. Edit 2: The issue is reproducible in Windows 11 x64 on version1.11.1b.https://github.com/user-attachments/assets/a7078e98-cdcd-4326-abb5-f3176c00a613