semantic-pull-requests: Plugin is not working at all
Following the documentation it should be “zero” configuration plugin. After the add to our organization (with a first test on only some repositories) the plugin is present but it taking no action at all.
The actual configuration we have:
But when we want to activate the check on the branch it is not visible:
We even try to activate the plugin forcing the configuration into the .github folder
Is there anything we are missing?
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 1
- Comments: 19 (7 by maintainers)
Lying in bed this evening putting my kids to sleep, pondering the great mysteries of the universe, it came to me! I think the bot stopped working for private repositories when https://github.com/probot/semantic-pull-requests/pull/30 landed, which introduced support for configuration of the bot using a
.github/semantic.ymlfile. The GitHub App’s token doesn’t include a scope for reading repository contents. For public repos this change had no negative effects because unauthenticated API requests for files still work, but for private repos those requests are likely now failing and causing the bot to fall over.@paszkowskiDamian based on your comment above, the timing sounds about right, as #30 landed on November 28.
One way to work around this would be to preserve the current minimally-invasive token scope by disallowing
semantic.ymlconfiguration for private repos, but that seems weird to have a different behavior between public and private repos. 🤔I think the best option now is to update the GitHub app to require read access to repository contents. Are folks willing to give this bot read access to their private repo contents, though?