metro: Initialization ordering issue causes multiple instances of scoped class to be created in graph

Description

We have a scoped class with a contributed binding and see multiple instances of this class being created in the same instance of the graph. I can provide reports in addition to the info below.

Self-contained Reproducer

I wasn’t able to create a reproducer, I assume because it requires a certain size in the graph to happen.

Metro version

0.4.0

Context

The class in question is defined like this

@Inject
@SingleIn(AppScope::class)
@ContributesBinding(AppScope::class, ThemeSelector::class)
class AppThemeSelector(
    dataStoreFactory: DataStoreFactory,
    fileSystemFactory: FileSystemFactory,
) : ThemeSelector, LogoutCallback { ... }

This is what AppThemeSelector looks like in the graph dump:

Type: com.freeletics.domain.themeselection.AppThemeSelector
├─ Binding: ConstructorInjected
├─ Contextual Type: com.freeletics.domain.themeselection.AppThemeSelector
├─ Scope: @SingleIn(AppScope::class)
├─ Dependencies:
│  ├─ com.freeletics.core.datastore.DataStoreFactory
│  │  └─ Parameter: dataStoreFactory (com.freeletics.core.datastore.DataStoreFactory)
│  ├─ com.freeletics.core.filesystem.FileSystemFactory
│  │  └─ Parameter: fileSystemFactory (com.freeletics.core.filesystem.FileSystemFactory)
├─ Parameters:
│  └─ <this>: com.freeletics.domain.themeselection.AppThemeSelector.$$MetroFactory
│  └─ dataStoreFactory: com.freeletics.core.datastore.DataStoreFactory
│  └─ fileSystemFactory: com.freeletics.core.filesystem.FileSystemFactory
──────────────────────────────────────────────────
Type: com.freeletics.domain.themeselection.AppThemeSelector.$$MetroContributionToAppScope
├─ Binding: Alias
├─ Contextual Type: com.freeletics.domain.themeselection.AppThemeSelector.$$MetroContributionToAppScope
├─ Aliased type: com.freeletics.app.freeletics.AppComponent
──────────────────────────────────────────────────
Type: com.freeletics.domain.themeselection.ThemeSelector
├─ Binding: Alias
├─ Contextual Type: com.freeletics.domain.themeselection.ThemeSelector
├─ Aliased type: com.freeletics.domain.themeselection.AppThemeSelector
├─ Dependencies:
│  ├─ com.freeletics.domain.themeselection.AppThemeSelector
│  │  └─ Parameter: instance (com.freeletics.domain.themeselection.AppThemeSelector)
├─ Parameters:
│  └─ <this>: com.freeletics.domain.themeselection.AppThemeSelector.$$MetroContributionToAppScope
│  └─ instance: com.freeletics.domain.themeselection.AppThemeSelector

There are 2 separate usages

@Inject 
@SingleIn(AppScope::class)
@ContributesMultibinding(AppScope::class, AppStartInitializer::class)
class AppLaunchListener(
    // ...
    private val themeSelector: ThemeSelector,
    // ...
) : AppStartInitializer { ... }

and

@ContributesTo(AppScope::class)
interface RxComponent {
    val themeSelector: ThemeSelector
}

Looking at the bytecode of the generated graph, this is the initialization of the provider field which looks fine

4009: getstatic     #138                // Field dev/zacsweers/metro/internal/DoubleCheck.Companion:Ldev/zacsweers/metro/internal/DoubleCheck$Companion;
4012: getstatic     #1166               // Field com/freeletics/domain/themeselection/AppThemeSelector$$$MetroFactory.Companion:Lcom/freeletics/domain/themeselection/AppThemeSelector$$$MetroFactory$Companion;
4015: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
4018: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
4021: checkcast     #35                 // class dev/zacsweers/metro/Provider
4024: aload_0
4025: getfield      #133                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
4028: invokevirtual #1169               // Method com/freeletics/domain/themeselection/AppThemeSelector$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
4031: checkcast     #35                 // class dev/zacsweers/metro/Provider
4034: invokevirtual #160                // Method dev/zacsweers/metro/internal/DoubleCheck$Companion.provider:(Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/Provider;
4037: putfield      #1679               // Field appThemeSelectorProvider:Ldev/zacsweers/metro/Provider;

Earlier in the constructor the provider for AppLaunchListener where ThemeSelector is injected into is created and that seems to directly call the AppThemeSelector factory instead of using the memoized provider from the graph. (in 2669 and 2685)

2522: getstatic     #196                // Field dev/zacsweers/metro/internal/DoubleCheck.Companion:Ldev/zacsweers/metro/internal/DoubleCheck$Companion;
2525: getstatic     #1115               // Field com/freeletics/domain/appstartsync/AppLaunchListener$$$MetroFactory.Companion:Lcom/freeletics/domain/appstartsync/AppLaunchListener$$$MetroFactory$Companion;
2528: getstatic     #1120               // Field com/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory$Companion;
2531: aload_0
2532: getfield      #130                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
2535: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
2538: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
2541: checkcast     #35                 // class dev/zacsweers/metro/Provider
2544: invokevirtual #1123               // Method com/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2547: checkcast     #35                 // class dev/zacsweers/metro/Provider
2550: getstatic     #1128               // Field com/freeletics/common/tracking/generated/InstallTracker$$$MetroFactory.Companion:Lcom/freeletics/common/tracking/generated/InstallTracker$$$MetroFactory$Companion;
2553: aload_0
2554: getfield      #100                // Field delegatingTrackerProvider:Ldev/zacsweers/metro/Provider;
2557: aload_0
2558: getfield      #292                // Field provideContextProvider_:Ldev/zacsweers/metro/Provider;
2561: aload_0
2562: getfield      #103                // Field realFeatureFlagProviderProvider:Ldev/zacsweers/metro/Provider;
2565: getstatic     #1133               // Field com/freeletics/domain/tracking/provider/RealGlobalPropertyProvider$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/RealGlobalPropertyProvider$$$MetroFactory$Companion;
2568: aload_0
2569: getfield      #191                // Field provideBaseAppInfoProvider:Ldev/zacsweers/metro/Provider;
2572: aload_0
2573: getfield      #259                // Field provideSystemClockProvider:Ldev/zacsweers/metro/Provider;
2576: aload_0
2577: getfield      #647                // Field provideTimeZoneProvider:Ldev/zacsweers/metro/Provider;
2580: getstatic     #1120               // Field com/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory$Companion;
2583: aload_0
2584: getfield      #130                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
2587: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
2590: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
2593: checkcast     #35                 // class dev/zacsweers/metro/Provider
2596: invokevirtual #1123               // Method com/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2599: checkcast     #35                 // class dev/zacsweers/metro/Provider
2602: getstatic     #1138               // Field com/freeletics/domain/tracking/provider/AppsFlyerIdProviderImpl$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/AppsFlyerIdProviderImpl$$$MetroFactory$Companion;
2605: aload_0
2606: getfield      #152                // Field provideContextProvider:Ldev/zacsweers/metro/Provider;
2609: aload_0
2610: getfield      #636                // Field provideAppsFlyerLibProvider:Ldev/zacsweers/metro/Provider;
2613: getstatic     #1143               // Field com/freeletics/domain/tracking/consent/RealConsentStore$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/consent/RealConsentStore$$$MetroFactory$Companion;
2616: aload_0
2617: getfield      #130                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
2620: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
2623: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
2626: checkcast     #35                 // class dev/zacsweers/metro/Provider
2629: aload_0
2630: getfield      #127                // Field realLoggedInUserManagerProvider:Ldev/zacsweers/metro/Provider;
2633: aload_0
2634: getfield      #259                // Field provideSystemClockProvider:Ldev/zacsweers/metro/Provider;
2637: invokevirtual #1148               // Method com/freeletics/domain/tracking/consent/RealConsentStore$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2640: checkcast     #35                 // class dev/zacsweers/metro/Provider
2643: invokevirtual #1153               // Method com/freeletics/domain/tracking/provider/AppsFlyerIdProviderImpl$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2646: checkcast     #35                 // class dev/zacsweers/metro/Provider
2649: aload_0
2650: getfield      #127                // Field realLoggedInUserManagerProvider:Ldev/zacsweers/metro/Provider;
2653: aload_0
2654: getfield      #167                // Field provideLocaleLangProvider:Ldev/zacsweers/metro/Provider;
2657: invokevirtual #1158               // Method com/freeletics/domain/tracking/provider/RealGlobalPropertyProvider$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2660: checkcast     #35                 // class dev/zacsweers/metro/Provider
2663: invokevirtual #1161               // Method com/freeletics/common/tracking/generated/InstallTracker$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2666: checkcast     #35                 // class dev/zacsweers/metro/Provider
2669: getstatic     #1166               // Field com/freeletics/domain/themeselection/AppThemeSelector$$$MetroFactory.Companion:Lcom/freeletics/domain/themeselection/AppThemeSelector$$$MetroFactory$Companion;
2672: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
2675: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
2678: checkcast     #35                 // class dev/zacsweers/metro/Provider
2681: aload_0
2682: getfield      #130                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
2685: invokevirtual #1169               // Method com/freeletics/domain/themeselection/AppThemeSelector$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2688: checkcast     #35                 // class dev/zacsweers/metro/Provider
2691: getstatic     #1174               // Field com/freeletics/common/tracking/generated/AppOpenAndCloseTracker$$$MetroFactory.Companion:Lcom/freeletics/common/tracking/generated/AppOpenAndCloseTracker$$$MetroFactory$Companion;
2694: aload_0
2695: getfield      #100                // Field delegatingTrackerProvider:Ldev/zacsweers/metro/Provider;
2698: aload_0
2699: getfield      #292                // Field provideContextProvider_:Ldev/zacsweers/metro/Provider;
2702: aload_0
2703: getfield      #103                // Field realFeatureFlagProviderProvider:Ldev/zacsweers/metro/Provider;
2706: getstatic     #1133               // Field com/freeletics/domain/tracking/provider/RealGlobalPropertyProvider$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/RealGlobalPropertyProvider$$$MetroFactory$Companion;
2709: aload_0
2710: getfield      #191                // Field provideBaseAppInfoProvider:Ldev/zacsweers/metro/Provider;
2713: aload_0
2714: getfield      #259                // Field provideSystemClockProvider:Ldev/zacsweers/metro/Provider;
2717: aload_0
2718: getfield      #647                // Field provideTimeZoneProvider:Ldev/zacsweers/metro/Provider;
2721: getstatic     #1120               // Field com/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory$Companion;
2724: aload_0
2725: getfield      #130                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
2728: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
2731: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
2734: checkcast     #35                 // class dev/zacsweers/metro/Provider
2737: invokevirtual #1123               // Method com/freeletics/domain/tracking/provider/RealSessionIdTrackingProvider$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2740: checkcast     #35                 // class dev/zacsweers/metro/Provider
2743: getstatic     #1138               // Field com/freeletics/domain/tracking/provider/AppsFlyerIdProviderImpl$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/provider/AppsFlyerIdProviderImpl$$$MetroFactory$Companion;
2746: aload_0
2747: getfield      #152                // Field provideContextProvider:Ldev/zacsweers/metro/Provider;
2750: aload_0
2751: getfield      #636                // Field provideAppsFlyerLibProvider:Ldev/zacsweers/metro/Provider;
2754: getstatic     #1143               // Field com/freeletics/domain/tracking/consent/RealConsentStore$$$MetroFactory.Companion:Lcom/freeletics/domain/tracking/consent/RealConsentStore$$$MetroFactory$Companion;
2757: aload_0
2758: getfield      #130                // Field realFileSystemFactoryProvider:Ldev/zacsweers/metro/Provider;
2761: getstatic     #867                // Field com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.INSTANCE:Lcom/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory;
2764: invokevirtual #868                // Method com/freeletics/core/datastore/RealDataStoreFactory$$$MetroFactory.create:()Ldev/zacsweers/metro/internal/Factory;
2767: checkcast     #35                 // class dev/zacsweers/metro/Provider
2770: aload_0
2771: getfield      #127                // Field realLoggedInUserManagerProvider:Ldev/zacsweers/metro/Provider;
2774: aload_0
2775: getfield      #259                // Field provideSystemClockProvider:Ldev/zacsweers/metro/Provider;
2778: invokevirtual #1148               // Method com/freeletics/domain/tracking/consent/RealConsentStore$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2781: checkcast     #35                 // class dev/zacsweers/metro/Provider
2784: invokevirtual #1153               // Method com/freeletics/domain/tracking/provider/AppsFlyerIdProviderImpl$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2787: checkcast     #35                 // class dev/zacsweers/metro/Provider
2790: aload_0
2791: getfield      #127                // Field realLoggedInUserManagerProvider:Ldev/zacsweers/metro/Provider;
2794: aload_0
2795: getfield      #167                // Field provideLocaleLangProvider:Ldev/zacsweers/metro/Provider;
2798: invokevirtual #1158               // Method com/freeletics/domain/tracking/provider/RealGlobalPropertyProvider$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2801: checkcast     #35                 // class dev/zacsweers/metro/Provider
2804: invokevirtual #1177               // Method com/freeletics/common/tracking/generated/AppOpenAndCloseTracker$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2807: checkcast     #35                 // class dev/zacsweers/metro/Provider
2810: aload_0
2811: getfield      #85                 // Field realHealthConnectManagerProvider:Ldev/zacsweers/metro/Provider;
2814: getstatic     #1182               // Field com/freeletics/domain/notifications/RealNotificationPermissionChecker$$$MetroFactory.Companion:Lcom/freeletics/domain/notifications/RealNotificationPermissionChecker$$$MetroFactory$Companion;
2817: aload_0
2818: getfield      #152                // Field provideContextProvider:Ldev/zacsweers/metro/Provider;
2821: getstatic     #1187               // Field com/freeletics/core/permissions/RealPermissionChecker$$$MetroFactory.Companion:Lcom/freeletics/core/permissions/RealPermissionChecker$$$MetroFactory$Companion;
2824: aload_0
2825: getfield      #152                // Field provideContextProvider:Ldev/zacsweers/metro/Provider;
2828: invokevirtual #1190               // Method com/freeletics/core/permissions/RealPermissionChecker$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2831: checkcast     #35                 // class dev/zacsweers/metro/Provider
2834: aload_0
2835: getfield      #1036               // Field notificationPermissionsDataStoreProvider:Ldev/zacsweers/metro/Provider;
2838: invokevirtual #1193               // Method com/freeletics/domain/notifications/RealNotificationPermissionChecker$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2841: checkcast     #35                 // class dev/zacsweers/metro/Provider
2844: aload_0
2845: getfield      #658                // Field provideBaseStreakReminderChannelProvider:Ldev/zacsweers/metro/Provider;
2848: aload_0
2849: getfield      #669                // Field provideCoachReminderChannelProvider:Ldev/zacsweers/metro/Provider;
2852: getstatic     #1198               // Field com/freeletics/domain/notifications/NotificationsModule$ProvideAudioPlayerChannel$$MetroFactory.Companion:Lcom/freeletics/domain/notifications/NotificationsModule$ProvideAudioPlayerChannel$$MetroFactory$Companion;
2855: aload_0
2856: getfield      #46                 // Field appComponentProvider:Ldev/zacsweers/metro/Provider;
2859: invokeinterface #141,  1          // InterfaceMethod dev/zacsweers/metro/Provider.invoke:()Ljava/lang/Object;
2864: checkcast     #314                // class com/freeletics/domain/notifications/NotificationsModule
2867: invokevirtual #1201               // Method com/freeletics/domain/notifications/NotificationsModule$ProvideAudioPlayerChannel$$MetroFactory$Companion.create:(Lcom/freeletics/domain/notifications/NotificationsModule;)Ldev/zacsweers/metro/internal/Factory;
2870: checkcast     #35                 // class dev/zacsweers/metro/Provider
2873: aload_0
2874: getfield      #322                // Field provideBrazeChannelProvider:Ldev/zacsweers/metro/Provider;
2877: aload_0
2878: getfield      #680                // Field provideCommunityChannelProvider:Ldev/zacsweers/metro/Provider;
2881: getstatic     #1206               // Field com/freeletics/domain/notifications/NotificationsModule$ProvideTrainingTimerChannel$$MetroFactory.Companion:Lcom/freeletics/domain/notifications/NotificationsModule$ProvideTrainingTimerChannel$$MetroFactory$Companion;
2884: aload_0
2885: getfield      #46                 // Field appComponentProvider:Ldev/zacsweers/metro/Provider;
2888: invokeinterface #141,  1          // InterfaceMethod dev/zacsweers/metro/Provider.invoke:()Ljava/lang/Object;
2893: checkcast     #314                // class com/freeletics/domain/notifications/NotificationsModule
2896: invokevirtual #1209               // Method com/freeletics/domain/notifications/NotificationsModule$ProvideTrainingTimerChannel$$MetroFactory$Companion.create:(Lcom/freeletics/domain/notifications/NotificationsModule;)Ldev/zacsweers/metro/internal/Factory;
2899: checkcast     #35                 // class dev/zacsweers/metro/Provider
2902: invokevirtual #1214               // Method com/freeletics/domain/appstartsync/AppLaunchListener$$$MetroFactory$Companion.create:(Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/internal/Factory;
2905: checkcast     #35                 // class dev/zacsweers/metro/Provider
2908: invokevirtual #214                // Method dev/zacsweers/metro/internal/DoubleCheck$Companion.provider:(Ldev/zacsweers/metro/Provider;)Ldev/zacsweers/metro/Provider;
    2911: putfield      #1217               // Field appLaunchListenerProvider:Ldev/zacsweers/metro/Provider;

From what I can see IrGraphGenerator.generate has initOrder.asSequence() which loops over all bindings, creates the fields for each and calls generateBindingCode. The created fields are added to providerFields and generateBindingCode returns early if a provider field is already there to use that field.

When I added some logs into I saw the following:

  1. generateBindingCodeis called for AppLaunchListener as a ConstructorInjected binding
  2. When going through AppLaunchListener’s parameters generateBindingCode is called for the ThemeSelector alias binding
  3. From the alias binding, generateBindingCode is called for AppThemeSelector’s ConstructorInjected binding
  4. providerFields does not contain anything for AppThemeSelector, so code to call the factory is generated
  5. generateBindingCode is called for AppThemeSelector’s ConstructorInjected binding

So AppThemeSelector’s should be created before AppLaunchListener so that it is already present in providerFields but because the order is swapped, it isn’t there which causes multiple instances to be created.

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 18 (13 by maintainers)

Most upvoted comments

Awesome, thanks folks. Gabriel was debugging with me and a partial solution was working prior to this one that put us on the right track. He’s gonna give it a try when he has a chance but may not be till friday, but given the above confirmations I’ll merge the above as soon as I can get some tests in place

The fix works for me as well! 🙇

I’ve put up a WIP in https://github.com/ZacSweers/metro/pull/683

Nice! Just tested out the branch and it fixes the issue for us. Our repro was very similar to @blackmailcz’s, where we have a dependency cycle worked around using kotlin.Lazy.

Looking good! App is no longer crashing, and after checking the Companion.create calls in all four Kotlin graph dumps, I did not find any mistake.

Good job! 💪 👌

Does it reproduce if you just create a graph of the (expected) chain of minimized dependencies?

I.e. if you have a Graph -> Taco -> Meat -> Seasoning expected chain that you are seeing not working correctly, can you replicate that chain in an isolated graph and see if that reproduces?

Separately, and more of a general question, if I added a mode to obfuscate typekey/file names in the reports directory with some user-provided key, would that be allowable for folks to share (even via DM in slack or email) their reports directory?

No dependency cycle, the only thing notable is the ContributesMultibinding on AppLaunchListener where it’s injected, but that alone wasn’t enough to reproduce it for me