youtube-dl: National Geographic url not recognized / [generic] / Unsupported URL

@JamKage, any progress on the National Geographic #26785? It’s still not able to be downloaded by YouTube-dl; as it was flagged to have “conflicts that must be resolved” before it is the “PR is merged” as well. Your assistance on it will be very much appreciated, just as the Fxnetworks that is now running fine. Thanks.

I managed to get this working with the following patch:

Add the following brand to the _SITE_INFO dictionary in go.py:

'nationalgeographic': {
    'brand': '026', 
    'requestor_id': 'dtci',
}

And replace the following line:

(?P<sub_domain_2>abc|freeform|disneynow)

With:

(?:www\.)?(?P<sub_domain_2>abc|freeform|disneynow|nationalgeographic)

Actually since my comment, thanks to this commit by @dstftw, the third step is no longer needed.

Using this episode as the example though, looks like one needs to:

Add two brands to the dictionary or whatever it’s called in go.py. Between lines 40-41, paste the following:

        },
        'nationalgeographic': {
            'brand': '024',
            'requestor_id': 'dtci',
        },
        'natgeo': {
            'brand': '026',
            'requestor_id': 'dtci',

Note: I don’t know which of the two are actually needed now.

Then, on the line reading (?P<sub_domain_2>, add |nationalgeographic to it.

There’s an issue with retrieving the video ID in the code, but I haven’t looked at the logic for that yet. Assume it’s because they once again changed the layout to something like: “videoIdCode”:“vdka15374108” which probably hasn’t been accounted for.

This looks identical to the scheme used on Disney’s Go platform. I’m sure adding yet another brand to it is relatively trivial—I may give it a shot myself to see if it’s doable, as I amateurishly fixed a related issue, but as I’m not actually putting a pull request in, who knows how long the fix will take to be put into an official release.

Update: Yep, just as trivial as I expected, though looks as if the Adobe pass credentials break for me, but it should get you started. What I did:

1. Add another brand to the dictionary or whatever it’s called in go.py. Between lines 40-41, paste the following:

        },
       'nationalgeographic': {
           'brand': '024',
           'requestor_id': 'dtci',
   

2. Change VALID_URL, such that it reads:
   _VALID_URL = r'https?://(?:www\.)?(?:(?:(?P<sub_domain>%s)(?:\.go)?)?|(?P<sub_domain_2>disneynow))\.com/(?:(?:[^/]+/)*(?P<id>vdka\w+)|(?:[^/]+/)*(?P<display_id>[^/?#]+))'\
3. In the _real_extract section, change the regexp for video_id to read: r'"id":["\']*(VDKA\w+)', webpage, 'video id',