MeshCentral: Sometimes when editing a file (meshagent.msh in this case) the file does not display properly

Describe the bug Recently I needed to change the URL in all of my agents. I used File, found the meshagent.msh file and in most cases could change the URL fine. In some cases, I would get text in the editor that did not seem to have anything to with the file. In some cases, I could close the editor and do a refresh and re-open and it would then display fine but in other cases, nothing I have found yet would correct the issue and I had to go into the desktop of the client and change the URL in the file on the device itself.

Screenshots NORMAL: image (4) FAILURE: image (3)

Server Software (please complete the following information):

  • OS: Windows 11 Pro
  • Virtualization: [e.g. Docker]
  • Network: LAN/WAN
  • Version: [e.g. 1.1.20]
  • Node: [e.g. 14.17.1]

Client Device (please complete the following information):

  • Device: Desktop computer
  • OS: Windows 10/11 Pro
  • Network: LAN/WAN
  • Browser: Google Chrome

Remote Device (please complete the following information):

  • Device: Desktop
  • OS: WIndows 11 22H2
  • Network: LAN/WAN
  • Current Core Version (if known): [Dec 9 2022, 65040331

My config.json

{
    "settings": {
        "cert": "mc.xxxxx.net",
        "minify": true,
        "port": 443,
        "_aliasport": 443,
        "_exactports": true,
        "redirport": 80
    },
    "domains": {
        "": {
            "title": "Tom Beattie MeshCentral"
        }
    },
    "smtp": {
        "host": "mail.xxxxx.net",
        "port": 587,
        "from": "xxxx@xxxxx.net",
        "user": "xxxx.kmeat",
        "tls": true,
        "_verifyEmail": false
    },
    "letsencrypt": {
    "__comment__": "Requires NodeJS 8.x or better, Go to https://letsdebug.net/ first before trying Let's Encrypt.",
    "email": "tomdeaxxxxx@gmail.com",
    "names": "mc.xxxxx.net",
    "production": true
  }
}

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 26 (5 by maintainers)

Commits related to this issue

Most upvoted comments

OMFG, would you guys believe me if i said the fix is one simple line and 1 simple word! after spending the whole of yday and this afternon double checking my finds! https://github.com/Ylianst/MeshCentral/blob/c1e3354c918516b4777a46e7ed04b126423203b3/agents/meshcore.js#L3340 change on line 3340 in meshcore.js the word while to if then restart meshcentral, wait a few mins, then give it a try!

I found one that messed up, just before my head hit the keyboard. Long day. I’ll apply the patch to it tomorrow and report back.

On Fri, Aug 16, 2024 at 8:28 AM Simon Smith @.***> wrote:

@Tomtreas https://github.com/Tomtreas are you still having the issue now at all? did you also try applying the patch i gave from above in the new version 1.1.27?

— Reply to this email directly, view it on GitHub https://github.com/Ylianst/MeshCentral/issues/5813#issuecomment-2293512144, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASI6M6VXQ7VTHJNZGADTECDZRX47VAVCNFSM6AAAAABDNQKBG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTGUYTEMJUGQ . You are receiving this because you were mentioned.Message ID: @.***>

@JSuenram keep ya file sizes under 16k? “simple” 😆

@JSuenram any chance you can email me/upload an example file that causes this issue? will try have a look into it

Sure, how can I send it to your gmail.com if that is ok?

Update: Mail send…